Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Missing VersionID for versioned buckets in API (#4796)

Browse Source
This commit is contained in:
Roman Rader 2022-01-27 01:24:51 +02:00 committed by GitHub
parent 76605e30a0
commit fc1ef55adc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
AUTHORS.md
View File

@ -60,3 +60,4 @@ Moto is written by Steve Pulec with contributions from:
* [Kyle Jones](https://github.com/Kerl1310) * [Kyle Jones](https://github.com/Kerl1310)
* [Mickaël Schoentgen](https://github.com/BoboTiG) * [Mickaël Schoentgen](https://github.com/BoboTiG)
* [Ariel Beck](https://github.com/arielb135) * [Ariel Beck](https://github.com/arielb135)
* [Roman Rader](https://github.com/rrader/)

3
moto/s3/responses.py
View File

@ -1272,6 +1272,9 @@ class ResponseObject(_TemplateEnvironmentMixin, ActionAuthenticatorMixin):
elif key is None: elif key is None:
raise MissingVersion() raise MissingVersion()
if key.version_id:
response_headers["x-amz-version-id"] = key.version_id
if key.storage_class == "GLACIER": if key.storage_class == "GLACIER":
raise InvalidObjectState(storage_class="GLACIER") raise InvalidObjectState(storage_class="GLACIER")
if if_unmodified_since: if if_unmodified_since:

2
tests/test_s3/test_s3.py
View File

@ -3562,6 +3562,7 @@ def test_boto3_put_object_tagging_on_earliest_version():
# Older version has tags while the most recent does not # Older version has tags while the most recent does not
resp = s3.get_object_tagging(Bucket=bucket_name, Key=key, VersionId=first_object.id) resp = s3.get_object_tagging(Bucket=bucket_name, Key=key, VersionId=first_object.id)
resp["VersionId"].should.equal(first_object.id)
resp["ResponseMetadata"]["HTTPStatusCode"].should.equal(200) resp["ResponseMetadata"]["HTTPStatusCode"].should.equal(200)
sorted_tagset = sorted(resp["TagSet"], key=lambda t: t["Key"]) sorted_tagset = sorted(resp["TagSet"], key=lambda t: t["Key"])
sorted_tagset.should.equal( sorted_tagset.should.equal(
@ -3571,6 +3572,7 @@ def test_boto3_put_object_tagging_on_earliest_version():
resp = s3.get_object_tagging( resp = s3.get_object_tagging(
Bucket=bucket_name, Key=key, VersionId=second_object.id Bucket=bucket_name, Key=key, VersionId=second_object.id
) )
resp["VersionId"].should.equal(second_object.id)
resp["ResponseMetadata"]["HTTPStatusCode"].should.equal(200) resp["ResponseMetadata"]["HTTPStatusCode"].should.equal(200)
resp["TagSet"].should.equal([]) resp["TagSet"].should.equal([])