Tay Frost
15b3ede3cc
Add test for case where ebs volume has no tags.
...
This commit adds a test for a case where an EBS volume has no tags. When
an EBS volume has no tags, calls to the aws ec2 endpoints `create_volume`
and `describe_volumes` do not include the `Tags` key in the
`response.Volumes[]` object.
However, moto does include the `Tags` key in this case. This discrepancy
in behaviour can result in code passing a moto test but failing in
production.
Sample snippets that trigger this condition:
```
def create_volume_and_then_get_tags_from_response():
client = boto3.client('ec2', region_name='us-east-1')
volume_response = client.create_volume(
Size=10,
AvailabilityZone='us-east-1a'
)
keys = volume_response['Keys']
```
```
def create_volume_and_then_get_tags_from_describe_volumes():
client = boto3.client('ec2', region_name='us-east-1')
volume_response = client.create_volume(
Size=10,
AvailabilityZone='us-east-1a'
)
volume_describe_response = client.describe_volumes()
keys = volume_describe_response['Volumes'][0]['Keys']
```
Both sample snippets will succeed in a moto test, but fail with a
`KeyError` when using the aws api.
2019-03-07 17:25:18 -05:00
Mike Grima
5a20755565
Merge pull request #2095 from mikegrima/configfix
...
Add Config mock to init
2019-03-07 13:19:34 -08:00
Mike Grima
d6022417f5
Forgot to add Config to the __init__.py
.
2019-03-07 12:53:01 -08:00
Mike Grima
7eaf6bf595
Merge pull request #2062 from domtes/fix_copy_key_with_unicode
...
Fixing S3 copy_key error when using unicode.
2019-03-04 11:48:46 -08:00
Mike Grima
ef74e19000
Merge pull request #2074 from jmehnle/patch-1
...
IMPLEMENTATION_COVERAGE.md: SQS get_queue_url is implemented
2019-03-04 11:41:13 -08:00
Mike Grima
9158c1356f
Merge pull request #2091 from whummer/fix/dict-sorted
...
Fix sorting of log groups
2019-03-04 11:04:42 -08:00
Mike Grima
848a4f451e
Merge pull request #2087 from mikegrima/config
...
Basic AWS Config service support.
2019-03-04 11:04:12 -08:00
Domenico Testa
74ff2ccc95
Reformatting to get better coverage results
2019-03-04 09:16:43 +01:00
Mike Grima
bc116ab750
Basic AWS Config service support.
2019-03-02 18:37:20 -08:00
Waldemar Hummer
840045c688
fix sorting of log groups
2019-03-02 18:56:49 -05:00
Mike Grima
b4fcbd79d8
Merge pull request #2081 from yan12125/patch-1
...
Bump idna to 2.8
2019-03-02 13:31:31 -08:00
Mark Challoner
d61ce0584b
Check record type when upserting.
...
Previously this was not checked so an existing record (e.g. with type A) would be overwritten on upsert by a record with the same name but different type (e.g. TXT).
This commit also:
* publicizes the type variable appending the underscore affix (required to maintain compatibility with CloudFormation which sets type as the CF type),
* fixes a wrong assumption in tests that UPSERT applies a change to Type (it creates a distinct record instead),
* Updates ACM model to use serial_number instead of deprecated and remove serial causing Travis failures.
2019-03-01 16:44:50 +00:00
Chih-Hsuan Yen
9992e23e68
Fix compatibility with cryptography 2.6
...
[1] https://github.com/pyca/cryptography/blob/master/CHANGELOG.rst#26---2019-02-27
2019-03-01 19:22:26 +08:00
Chih-Hsuan Yen
7b7cf5bd11
Bump idna to 2.8
...
requests 2.21.0 allows idna 2.8 [1]
[1] 8761e9736f
2019-03-01 17:14:18 +08:00
William Richard
a8384c0416
Fix serial number field
...
https://github.com/spulec/moto/pull/2077/files#diff-5fa8d19b019905e97d955f78d3dd1b99
2019-02-27 15:15:50 -05:00
Julian Mehnle
c43f311a5e
IMPLEMENTATION_COVERAGE.md: SQS get_queue_url is implemented
...
SQS get_queue_url was implemented in dbf2368aa
.
2019-02-25 21:10:36 -08:00
woohooyayaya
e6e7f235ac
fix creation date in create key response to unix timestamp type
2019-02-25 16:14:24 -08:00
Mike Grima
09855801ba
Merge pull request #2019 from acsbendi/launch_index
...
Correctly returning ami launch index
2019-02-25 12:16:40 -08:00
Mike Grima
3920f0e16b
Merge pull request #2060 from gregsterin/better-support-for-ddb-expressions
...
support a bit more of the dynamoDB ConditionExpression syntax
2019-02-25 10:03:02 -08:00
Mike Grima
7f0b1d6795
Merge pull request #2061 from rubelw/master
...
Update kms, iam and lambda to work with terraform
2019-02-25 09:58:55 -08:00
Berislav Kovacki
7e863b0260
Add attributes parameter support for sns create_topic API
2019-02-21 22:08:46 +01:00
William Rubel
a5208222b4
Fixing list entities for policy
2019-02-18 21:29:09 -06:00
William Rubel
59deb4d6c0
Fixing list entities for policy
2019-02-18 21:25:29 -06:00
William Rubel
e9d8021c86
Fixing list entities for policy
2019-02-18 21:20:29 -06:00
William Rubel
37845e41a6
Trying to improve coverage
2019-02-18 09:44:48 -06:00
William Rubel
c46bc9ae83
Trying to improve coverage
2019-02-18 09:15:07 -06:00
William Rubel
e229d248ad
Trying to improve coverage
2019-02-18 08:52:37 -06:00
William Rubel
8048e39dc0
Fix policy date
2019-02-17 22:32:39 -06:00
William Rubel
ce7b5ebf54
Fix policy date
2019-02-17 21:37:33 -06:00
William Rubel
37a765db8d
Fix policy date
2019-02-17 17:12:27 -06:00
William Rubel
63b692356d
Fix policy date
2019-02-17 16:49:54 -06:00
William Rubel
0e73cddf2f
Add test for roles
2019-02-17 16:25:49 -06:00
William Rubel
6e7bd088b3
Add test for roles
2019-02-17 16:04:28 -06:00
William Rubel
9e9e37eb62
Add test for roles
2019-02-17 15:35:49 -06:00
William Rubel
31258e9e9e
Add test for roles
2019-02-17 15:23:59 -06:00
William Rubel
37cb5ab4e6
Add test for roles
2019-02-17 14:36:53 -06:00
William Rubel
921a993330
cleaning up files
2019-02-17 14:30:43 -06:00
William Rubel
e35d99ff09
Trying to improve coverage
2019-02-17 09:25:35 -06:00
William Rubel
b29fd4a997
Adding additional tests to increase coverage
2019-02-16 20:53:54 -06:00
William Rubel
8ad28f8400
Adding additional tests to increase coverage
2019-02-16 20:53:27 -06:00
William Rubel
5372e6840f
Increasing code coverage
2019-02-16 12:37:46 -06:00
Domenico Testa
6897a118ed
Fixing S3 copy_key error when using unicode.
2019-02-16 16:42:00 +01:00
William Rubel
0a3ff94e66
Update kms and lambda to work with terraform
2019-02-16 09:37:27 -06:00
William Rubel
4c6f08d463
Update kms and lambda to work with terraform
2019-02-16 09:27:23 -06:00
Greg Sterin
c1232a7a23
linting
2019-02-15 13:49:42 -08:00
Greg Sterin
f035b9613d
support a bit more of the dynamoDB ConditionExpression syntax
2019-02-14 18:10:01 -08:00
John Corrales
a6f7f06c30
Merge branch 'master' into master
2019-02-11 17:51:18 -08:00
Mike Grima
1095b7d94b
Merge pull request #2050 from mikegrima/account_auth_fix
...
Fixed a bug in get_account_authorization_details for attached managed policies
2019-02-08 10:04:01 -08:00
Mike Grima
94672799cf
Fixed a bug in get_account_authorization_details for attached managed policies.
...
Fixed a bug in the XML template for `get_account_authorization_details` where attached managed policies
were empty strings.
2019-02-07 17:32:31 -08:00
Mike Grima
f41c4e756f
Merge pull request #2041 from mikegrima/roletags
...
IAM Role Tagging support
2019-02-06 11:40:59 -08:00