Commit Graph

1819 Commits

Author SHA1 Message Date
Mike Grima
51ef03b03b
Merge pull request #2133 from earlrob/add_keyid_to_kms_encrypt_and_decrypt
add KeyId value to kms.responses.encrypt and kms.responses.decrypt
2019-04-17 11:07:00 -07:00
Mike Grima
d8dbc6a49c
Merge pull request #2134 from ogckw/master
Fix #2129 EC2 tag should raise ClientError when resource is empty
2019-04-17 11:05:28 -07:00
Mike Grima
53f101774f
Merge pull request #2137 from devoto13/fix-missing-version-id
Fixed copy-object from unversioned bucket to versioned bucket
2019-04-17 11:04:15 -07:00
Mike Grima
c7dc09345a
Merge pull request #2143 from chriskilding/feature/secretsmanager-listsecrets
Feature: aws secretsmanager list-secrets
2019-04-17 11:03:19 -07:00
Santosh Ananthakrishnan
4f1a1a9d1e [iam] create_policy_version: Fix version id calculation
When creating a new IAM policy version with create_policy_version,
we cannot use the length of the versions list to calculate VersionId.
Keep track of the next version id to use as a non-decreasing counter.

Fixes #2157
2019-04-16 20:15:57 +00:00
Chris K
89e4ab93ee Implement ListSecrets 2019-04-05 13:33:28 +01:00
Yaroslav Admin
b85d21b8fe Fixed copy-object from unversioned bucket to versioned bucket
The response of the copy-object operation was missing VersionId property
when source bucket is not versioned.
2019-04-02 15:30:01 +02:00
Steve Pulec
66dafc6679
Merge pull request #2130 from spulec/bugfix/network-interface-and-private-ip
Add private IP to every NetworkInterface
2019-04-01 15:17:36 -05:00
hsuhans
6b7282f93c Fix #2129 EC2 tag should raise ClientError when resource is empty
Raise MissingParameterError exception in models/validate_resource_ids of ec2.

Add ec2 create tag with empty resource test case.
Add ec2 delete tag with empty resource test case.

Related: #2129

Reference
boto3 create_tags
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2.html#EC2.Client.create_tags

boto3 delete_tags
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2.html#EC2.Client.delete_tags

Amazon EC2 API Reference Actions CreateTags
https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_CreateTags.html

Amazon EC2 API Reference Actions DeleteTags
https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DeleteTags.html
2019-03-30 23:26:50 +08:00
Earl Robinson
dbdc8925e3 add KeyId value to kms.responses.encrypt and kms.responses.decrypt 2019-03-29 21:07:32 -04:00
Nick Venenga
d181897ec9
Add proper failure response to describe_clusters 2019-03-28 14:50:48 -04:00
Mike Grima
921b5a3227 Fixing broken tests #2126
- KMS
- S3
- CloudFormation (Thanks kgutwin!)
2019-03-28 10:09:03 -07:00
Hugo Lopes Tavares
7c62f4a75c Add test to CloudFormation and PrimaryPrivateIpAddress GetAtt
This test would raise an error before d4e39146b7
2019-03-27 16:28:18 -04:00
Hugo Lopes Tavares
d4e39146b7 Make sure every NetworkInterface has a private IP
AWS always assigns a primary IP address to Network Interfaces.
Using a test account (modified the IP):

    >>> import boto
    >>> vpc = boto.connect_vpc()
    >>> eni = vpc.create_network_interface(subnet_id)
    >>> eni.private_ip_addresses
    [PrivateIPAddress(10.1.2.3, primary=True)]
2019-03-27 16:27:10 -04:00
Mike Grima
6ecb840c61
Merge pull request #2100 from gilbsgilbs/non-versioned-bucket-consitency
[S3] Support null version ids for buckets with versioning disabled
2019-03-11 14:13:26 -07:00
Mike Grima
53b94606de
Merge pull request #2103 from mikegrima/config
Fixed validation bugs in put_configuration_recorder
2019-03-11 13:58:54 -07:00
Mike Grima
87a54b9d81
Merge pull request #2077 from markchalloner/mark-route53-upsert-type
Check record type when upserting.
2019-03-11 13:50:37 -07:00
Mike Grima
6d67418c41 Fixed validation bugs in put_configuration_recorder 2019-03-11 13:25:36 -07:00
Gilbert Gilb's
dedb53371e [S3] Support null version ids for buckets with versioning disabled 2019-03-09 10:21:49 +01:00
Tay Frost
15b3ede3cc Add test for case where ebs volume has no tags.
This commit adds a test for a case where an EBS volume has no tags. When
an EBS volume has no tags, calls to the aws ec2 endpoints `create_volume`
and `describe_volumes` do not include the `Tags` key in the
`response.Volumes[]` object.

However, moto does include the `Tags` key in this case. This discrepancy
in behaviour can result in code passing a moto test but failing in
production.

Sample snippets that trigger this condition:

```
def create_volume_and_then_get_tags_from_response():
    client = boto3.client('ec2', region_name='us-east-1')
    volume_response = client.create_volume(
        Size=10,
        AvailabilityZone='us-east-1a'
    )
    keys = volume_response['Keys']
```

```
def create_volume_and_then_get_tags_from_describe_volumes():
    client = boto3.client('ec2', region_name='us-east-1')
    volume_response = client.create_volume(
        Size=10,
        AvailabilityZone='us-east-1a'
    )
    volume_describe_response = client.describe_volumes()
    keys = volume_describe_response['Volumes'][0]['Keys']
```

Both sample snippets will succeed in a moto test, but fail with a
`KeyError` when using the aws api.
2019-03-07 17:25:18 -05:00
Mike Grima
7eaf6bf595
Merge pull request #2062 from domtes/fix_copy_key_with_unicode
Fixing S3 copy_key error when using unicode.
2019-03-04 11:48:46 -08:00
Mike Grima
bc116ab750 Basic AWS Config service support. 2019-03-02 18:37:20 -08:00
Mark Challoner
d61ce0584b
Check record type when upserting.
Previously this was not checked so an existing record (e.g. with type A) would be overwritten on upsert by a record with the same name but different type (e.g. TXT).

This commit also:

* publicizes the type variable appending the underscore affix (required to maintain compatibility with CloudFormation which sets type as the CF type),
* fixes a wrong assumption in tests that UPSERT applies a change to Type (it creates a distinct record instead),
* Updates ACM model to use serial_number instead of deprecated and remove serial causing Travis failures.
2019-03-01 16:44:50 +00:00
Mike Grima
09855801ba
Merge pull request #2019 from acsbendi/launch_index
Correctly returning ami launch index
2019-02-25 12:16:40 -08:00
Mike Grima
3920f0e16b
Merge pull request #2060 from gregsterin/better-support-for-ddb-expressions
support a bit more of the dynamoDB ConditionExpression syntax
2019-02-25 10:03:02 -08:00
William Rubel
e9d8021c86 Fixing list entities for policy 2019-02-18 21:20:29 -06:00
William Rubel
37845e41a6 Trying to improve coverage 2019-02-18 09:44:48 -06:00
William Rubel
c46bc9ae83 Trying to improve coverage 2019-02-18 09:15:07 -06:00
William Rubel
e229d248ad Trying to improve coverage 2019-02-18 08:52:37 -06:00
William Rubel
8048e39dc0 Fix policy date 2019-02-17 22:32:39 -06:00
William Rubel
ce7b5ebf54 Fix policy date 2019-02-17 21:37:33 -06:00
William Rubel
37a765db8d Fix policy date 2019-02-17 17:12:27 -06:00
William Rubel
0e73cddf2f Add test for roles 2019-02-17 16:25:49 -06:00
William Rubel
6e7bd088b3 Add test for roles 2019-02-17 16:04:28 -06:00
William Rubel
31258e9e9e Add test for roles 2019-02-17 15:23:59 -06:00
William Rubel
37cb5ab4e6 Add test for roles 2019-02-17 14:36:53 -06:00
William Rubel
921a993330 cleaning up files 2019-02-17 14:30:43 -06:00
William Rubel
e35d99ff09 Trying to improve coverage 2019-02-17 09:25:35 -06:00
William Rubel
8ad28f8400 Adding additional tests to increase coverage 2019-02-16 20:53:27 -06:00
William Rubel
5372e6840f Increasing code coverage 2019-02-16 12:37:46 -06:00
Domenico Testa
6897a118ed Fixing S3 copy_key error when using unicode. 2019-02-16 16:42:00 +01:00
William Rubel
4c6f08d463 Update kms and lambda to work with terraform 2019-02-16 09:27:23 -06:00
Greg Sterin
f035b9613d support a bit more of the dynamoDB ConditionExpression syntax 2019-02-14 18:10:01 -08:00
Mike Grima
94672799cf Fixed a bug in get_account_authorization_details for attached managed policies.
Fixed a bug in the XML template for `get_account_authorization_details` where attached managed policies
were empty strings.
2019-02-07 17:32:31 -08:00
Mike Grima
f41c4e756f
Merge pull request #2041 from mikegrima/roletags
IAM Role Tagging support
2019-02-06 11:40:59 -08:00
Mike Grima
dfceab9bf0 Some fixes to get_account_authorization_details 2019-02-04 13:44:01 -08:00
Mike Grima
142fc65260
Merge pull request #2014 from garyd203/dynamodb-set-comparison
Make EQ conditions on sets work reliably in DynamoDB
2019-02-01 11:49:48 -08:00
Mike Grima
d652755f3b
Merge pull request #2032 from drmorr0/spot_fleet_tag_specifications
tag specifications for spot fleet requests
2019-02-01 11:47:36 -08:00
Mike Grima
8d17271ee4
Merge pull request #2028 from acsbendi/network-acl-fixes
Network ACL fixes
2019-02-01 11:46:25 -08:00
Mike Grima
1a36c0c377 IAM Role Tagging support 2019-01-31 17:37:26 -08:00