Commit Graph

3089 Commits

Author SHA1 Message Date
Emile Fugulin
2d5e2e9c2b Detach principal from thing when it is deleted 2019-10-24 13:59:30 -04:00
Mike Grima
e9dc0c9a3a Fixed bugs in AWS Config Querying
- Fixed some log bugs in the Config querying APIs
- Fixed an issue with S3 ACLs when described from Config (it's actually
a double-wrapped JSON)
2019-10-23 22:32:45 -07:00
Jack Danger
902a35d5b9
Merge pull request #2493 from edekadigital/filter_logs_raises_if_filter_pattern
add NotImplementedError when filter_pattern is given to filter_log_events
2019-10-23 15:23:45 -07:00
Jack Danger
8ecd882a82
Merge pull request #2508 from bblommers/refactor-dynamodb-update-documentation
Refactor dynamodb update documentation
2019-10-23 15:21:06 -07:00
Jack Danger
61f153f168
Merge pull request #2509 from bblommers/feature/847
DynamoDB - Support list_append operation
2019-10-23 15:20:37 -07:00
cqueitzsch
8b2b9d3618 Fixing comparisons for python 3 in dynamodb 2019-10-23 12:59:19 -07:00
Bert Blommers
730c4be1a3 #847 - DynamoDB - Implement list_append feature when updating 2019-10-23 09:12:03 +01:00
Bert Blommers
e01fe02653 DynamoDB - Update doc for update-method 2019-10-23 08:06:15 +01:00
Jack Danger
b6fe526add
Merge pull request #2502 from bblommers/feature/lambda-delete-by-arn
Feature - Lambda Delete by arn
2019-10-22 16:02:33 -07:00
Jack Danger
a5d4a68922
Merge pull request #2501 from edekadigital/add-iam-virtual-mfa-device
Add iam virtual mfa device
2019-10-22 16:01:31 -07:00
Mike Grima
57dc6522f2
Merge pull request #2505 from mikegrima/configFix
Fixed a bug with S3 bucket policies for AWS Config
2019-10-22 15:53:18 -07:00
Mike Grima
9273db7e61 Fixed a bug with S3 bucket policies for AWS Config 2019-10-22 15:01:39 -07:00
Jack Danger
00045ae480
Merge branch 'master' into add-iam-virtual-mfa-device 2019-10-22 14:54:10 -07:00
Jack Danger
4d0099499f
Athena - implementing first two endpoints (#2506)
This implements create_work_group() and list_work_groups()
2019-10-22 14:37:29 -07:00
Jack Danger
a05c7da3bb
Implement support for lambda policies (#2471)
* Implement support for lambda policies

* Fixing two tests that weren't running

* Getting tests running under Python 2.7
2019-10-22 14:09:44 -07:00
Bert Blommers
64cf1fc2c9 Refactor DynamoDB update expressions (#2497)
* Refactor DynamoDB.update to use recursive method for nested updates

* Simplify DynamoDB.update_item logic
2019-10-22 12:40:41 -07:00
Mike Grima
fbc3301562
Merge pull request #2504 from csmurton/add-iam-delete-entity-constraints
Conflict detection for IAM delete_role and delete_user
2019-10-22 09:59:07 -07:00
Mike Grima
1cde5d37eb
Merge pull request #2483 from thincal/fix/list-objects-with-truncation
s3 list_object: return the NextMarker info if it's truncated
2019-10-22 09:57:15 -07:00
Chris Murton
ccdcb7ca60 Add conflict detection on IAM delete_role and delete_user 2019-10-22 14:27:49 +01:00
Bert Blommers
ce4bd5d64c AWS Lambda - Allow function deletions by ARN 2019-10-22 09:31:37 +01:00
gruebel
802fb3baad Connect user with virtual mfa device 2019-10-21 22:51:00 +02:00
gruebel
1d9382b5e5 Add iam.list_virtual_mfa_devices 2019-10-21 21:48:50 +02:00
LS
d3ed7ee240 s3 list_object: return the NextMarker info if it's truncated 2019-10-21 09:40:05 +08:00
gruebel
c80135a6db Add iam.delete_virtual_mfa_device 2019-10-20 23:03:20 +02:00
gruebel
9671730f16 Add iam.create_virtual_mfa_device 2019-10-20 22:39:57 +02:00
gruebel
cd8027ce9d Add iam.list_open_id_connect_providers 2019-10-18 21:15:48 +02:00
gruebel
f4af9a1d54 Add iam.delete_open_id_connect_provider 2019-10-18 21:15:48 +02:00
gruebel
c492c5c228 Add iam.get_open_id_connect_provider 2019-10-18 21:15:05 +02:00
gruebel
bd627b65f7 Add iam.create_open_id_connect_provider 2019-10-18 21:15:05 +02:00
Mike Grima
4dd347e1fe
Merge pull request #2487 from bblommers/feature/iam_delete_policy
Feature - [IAM] Delete Policy
2019-10-18 09:53:51 -07:00
Mike Grima
4ec52b946d
Merge pull request #2492 from edekadigital/fix_deprecation_warning
fix deprication warning invalid escape sequence
2019-10-18 09:53:07 -07:00
Mike Grima
484da34022
Merge pull request #2491 from bblommers/bugfix/250
DynamoDB - Add validation for Query Key Expression
2019-10-18 09:52:23 -07:00
Mike Grima
382fe5bd68
Merge pull request #2481 from aacampbell/fix_getsecretmananger_error
Fix getsecretmananger error
2019-10-18 09:50:43 -07:00
Selena
37877c6fb2 add NotImplementedError when filter_pattern is given to filter_log_events
fix #2419
2019-10-18 13:46:27 +02:00
Selena
e64b9ca0ef fix deprication warning invalid escape sequence
fix #2489
2019-10-18 12:52:05 +02:00
Bert Blommers
db206e994b #250 - DynamoDB - Add check for valid query keyconditionexpression 2019-10-18 09:58:09 +01:00
gruebel
ed1c799bdc CR fix 2019-10-18 09:04:29 +02:00
Alexander Campbell
30853a0b5c Use specialised exception for "secret has no value" scenario 2019-10-18 12:06:12 +11:00
Alexander Campbell
6120a60263 Use escape sequence to express non-ASCII character 2019-10-18 10:17:49 +11:00
Alexander Campbell
4eb921480e Use specific exception to prevent repetition 2019-10-18 10:17:45 +11:00
gruebel
19a34ea57a Add error handling for sqs.list_queue_tags 2019-10-17 22:38:16 +02:00
gruebel
dbfb319def Add error handling for sqs.tag_queue 2019-10-17 22:36:37 +02:00
gruebel
65c5502a62 Add error handling for sqs.send_message_batch 2019-10-17 22:09:14 +02:00
Bert Blommers
856a06a778 IAM - Delete Policy implementation 2019-10-17 09:28:19 +01:00
Harrison Termotto
df2de373b2 Add tagging to versioned s3 objects. 2019-10-17 00:16:16 -04:00
Mike Grima
16a0e93259
Merge pull request #2484 from koshigoe/bugfix/check-none-in-s3-model-get_key
Avoid exception occur in `moto.s3.models.S3Backend.get_key`
2019-10-16 10:29:19 -07:00
Stephen Huff
d1a13ed782 chore(rds2): make flake8 happy 2019-10-16 09:10:56 -04:00
koshigoe
98f33740e1
fix(s3): check whether key is None or not to avoid exception.
```
AttributeError: 'NoneType' object has no attribute 'multipart'
```
2019-10-16 18:13:59 +09:00
Alexander Campbell
9a54cea4f1 Work around python2 unicode exception str() issues 2019-10-16 14:44:41 +11:00
Alexander Campbell
d74f9e47c8 Add coding hint for python2 compatibility 2019-10-16 12:44:30 +11:00
Alexander Campbell
9d6a1ca81d Fix slightly incorrect message for some errors 2019-10-16 10:58:59 +11:00
Alexander Campbell
381e7b165f Raise appropriate error when secret exists but has no value 2019-10-16 10:55:03 +11:00
Stephen Huff
7b1cf9eecd fix(rds2): handle create_db_instance when AllocatedStorage is not specified
In all of the tests of `create_db_instance()`, the `AllocatedStorage`
parameter is provided.  The [RDS API
reference](https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_CreateDBInstance.html)
says this parameter is optional; however, when none is provided, moto
returns an obscure error message:

```
self = <botocore.parsers.QueryParser object at 0x113745890>, shape = <Shape(Integer)>, text = 'None'

    @_text_content
    def _handle_integer(self, shape, text):
>       return int(text)
E       ValueError: invalid literal for int() with base 10: 'None'

/usr/local/Cellar/pyenv/1.2.13_1/versions/3.7.4/envs/rds_encrypt/lib/python3.7/site-packages/botocore/parsers.py:466: ValueError
```

This PR adds default values that correspond to the current default API
behaviors.
2019-10-15 16:18:37 -04:00
Mike Grima
4da9ec1346
Merge pull request #2442 from titibike/sns_subscription_attributes
Issue #2441 Add informations in SNS subscriptions `attributes`
2019-10-15 10:05:20 -07:00
Mike Grima
cc96a5e659
Merge pull request #2357 from brodie-g/master
Existing user now raises a UsernameExistsException
2019-10-14 09:33:56 -07:00
Bert Blommers
009a97db85 Merge branch 'master' into bugfix/1823 2019-10-14 10:02:22 +01:00
Bert Blommers
106692ed88 #1823 - Add support to delete items from a nested list 2019-10-14 09:59:52 +01:00
Mike Grima
35d2f938af
Merge pull request #2478 from mikegrima/configbatch
Added AWS Config query batching capabilities
2019-10-13 19:31:13 -07:00
Steve Pulec
2118fc415a
Merge pull request #2477 from edekadigital/add-sqs-tags
Add tags parameter to sqs.create_queue
2019-10-13 16:51:21 -05:00
Mike Grima
96f0666df9 Added AWS Config batching capabilities
- Support for aggregated and non-aggregated batching
- Currently only implemented for S3
2019-10-13 12:28:09 -07:00
gruebel
ce3f1eed66 fix test server error 2019-10-13 20:32:53 +02:00
Mike Grima
893f0d4f83
Merge pull request #2463 from gruebel/fix-dynamodb-get-item-ProjectionExpression
Add ProjectionExpression & ExpressionAttributeNames to DynamoDB get_it…
2019-10-13 10:47:25 -07:00
Mike Grima
e2a27d8206
Merge pull request #2476 from mikegrima/configquery
Added initial support for querying AWS Config for S3
2019-10-13 10:40:18 -07:00
Mike Grima
2a2c3e80f0 Adding support for querying the AWS Config resource for S3.
- Need to add support still for batch requests and batch aggregation requests in a future PR
2019-10-13 10:14:15 -07:00
gruebel
0d8c81a211 fix CloudFormation tests 2019-10-13 17:18:11 +02:00
gruebel
49045fe680 Add tags parameter to sqs.create_queue 2019-10-13 14:51:31 +02:00
Mike Grima
e7f1ab3290
Merge pull request #2475 from edekadigital/add-sns-tags
Add sns tags
2019-10-12 15:42:25 -07:00
Mike Grima
c46ee4cf8d
Merge pull request #2474 from jrstarke/2473
Added Exception to describe_container_instances to match aws api
2019-10-12 15:41:02 -07:00
Mike Grima
f14d5ca6cb
Merge pull request #2470 from JackDanger/jackdanger/kinesis-extended-s3-config
Supporting more modern Firehose features
2019-10-12 15:38:57 -07:00
Mike Grima
d0a6c4380b
Merge pull request #2469 from bblommers/bugfix/2384
DynamoDB - Fixes query sorting on numerical values
2019-10-12 15:37:56 -07:00
gruebel
26ef792690 Add sns.untag_resource 2019-10-12 21:10:51 +02:00
gruebel
726775678c Add sns.tag_resource 2019-10-12 20:37:59 +02:00
Jamie Starke
017cbb52ca Added Exception to for describe_container_instances to match aws api 2019-10-11 22:13:55 -07:00
gruebel
8d527743d5 Add sns.list_tags_for_resource 2019-10-11 17:58:48 +02:00
gruebel
97c4174f30 Extract projection_expression adjustment 2019-10-11 14:30:25 +02:00
Jack Danger
0723fcf6e7 Supporting more modern Firehose features
This implements ExtendedS3DestinationConfiguration, allowing
serialization to Parquet and ORC formats as part of a Firehose
destination.
2019-10-10 17:44:09 -07:00
Steve Pulec
31198c75b8
Merge pull request #2457 from bblommers/feature/dynamodb_streams_invoke_lambda
Feature: Add option for DynamoDB stream to kick off lambda
2019-10-10 17:05:43 -05:00
Steve Pulec
34d4379b9f
Merge branch 'master' into bugfix/2384 2019-10-10 17:02:59 -05:00
Steve Pulec
359d6c9099
Merge pull request #2464 from sethblack/lambda-update-function-code-and-configuration
added UpdateFunctionCode and UpdateFunctionConfiguration and associat…
2019-10-10 17:01:31 -05:00
Steve Pulec
b60f720f0e
Merge pull request #2468 from bblommers/remove-dead-code
Remove dead code
2019-10-10 16:58:29 -05:00
Bert Blommers
a3f3d5661b
Merge pull request #6 from johnlpuc163/xu.bug_DynamoType_compare
Use cast_value when comparing DynamoType
2019-10-10 09:19:10 +01:00
Bert Blommers
ed6d780dab Remove dead code 2019-10-10 09:14:22 +01:00
Seth Black
dff24cb032 bringing up test percentage 2019-10-09 16:20:53 -05:00
Seth Black
20dc8ae5c4 getting tests working in server mode 2019-10-09 15:15:10 -05:00
Bert Blommers
afb8f71e9f #1822 - DynamoDB: Add List index operations 2019-10-09 17:30:42 +01:00
Bert Blommers
1fb844972f Merge branch 'master' into bugfix/1874 2019-10-09 08:33:53 +01:00
Seth Black
41af98c98b added UpdateFunctionCode and UpdateFunctionConfiguration and associated test cases 2019-10-08 15:59:03 -05:00
gruebel
cb43796daf Add ProjectionExpression & ExpressionAttributeNames o DynamoDB get_item & batch_get_item 2019-10-08 22:30:14 +02:00
JPNewman89
2ba0134bb7
linting 2019-10-08 14:46:57 +01:00
Bert Blommers
2d11e8feb4 Code improvements 2019-10-08 14:11:21 +01:00
John Newman
bae1a313e1 add tags to UsagePlan 2019-10-08 12:49:44 +01:00
John Newman
92b3898c21 remove mutable default arg 2019-10-08 12:48:59 +01:00
Bert Blommers
91b13f998f Feature: Add option for DynamoDB stream to kick off lambda 2019-10-07 11:11:22 +01:00
gruebel
c9d69681ec Add evaluation of ConditionExpression to DynamoDB2 delete_item 2019-10-06 16:49:02 +02:00
Bert Blommers
a389fdcd95
#1874 - Adjust for Python2/3 incompatibilities 2019-10-06 15:24:37 +01:00
Bert Blommers
dc89b47b40 #1874 - Count item size based on contents of actual dictionary 2019-10-06 14:08:58 +01:00
Mike Grima
e71c06738c
Merge pull request #2454 from mikegrima/s3lifecycle
Made fixes to the S3 Lifecycle mocks to be more consistent with the API
2019-10-05 12:56:33 -07:00
Mike Grima
7761542754
Merge pull request #2453 from gruebel/fix-ssm-ParameterStringFilter
Add ParameterFilters to SSM describe_parameters
2019-10-05 12:29:53 -07:00
Mike Grima
ab0853cddc Made fixes to the S3 Lifecycle mocks to be more consistent with the API. 2019-10-05 12:29:09 -07:00
Bert Blommers
4dec187d80 #1834 - Check item size in DynamoDB 2019-10-05 15:20:43 +01:00
gruebel
2cfd3398f6 Add ParameterFilters to SSM describe_parameters 2019-10-05 14:05:47 +02:00
Bert Blommers
71e86ab417 #1834 - Bugfix when removing item in double nested maps 2019-10-05 11:33:34 +01:00
Bert Blommers
d86dcb2ee9
Merge pull request #4 from ZoidBB/master
Initial work by ZoidBB
2019-10-05 10:18:17 +01:00
Steve Pulec
7de11b672b
Merge pull request #2449 from nadlerjessie/events-and-ecs-multi-region
Events and ecs multi region
2019-10-03 16:20:30 -05:00
Steve Pulec
59543c404a
Merge pull request #2450 from jimjshields/add-ecs-service-tag-resource
Add support for tagging and untagging ECS services
2019-10-03 16:04:14 -05:00
Mike Grima
d925335f05
Merge pull request #2443 from mikegrima/configquery
Adding support for querying AWS Config
2019-10-03 13:38:43 -07:00
Jessie Nadler
2424d63686 Use self.region_name to generate rule ARN 2019-10-03 15:29:54 -04:00
Jim Shields
6cb1173719 Add tag_resource and untag_resource for ECS services
* Refactor resource ARN parsing
2019-10-03 15:16:07 -04:00
Jessie Nadler
277cec0928 Add multi region support for Events 2019-10-03 15:15:11 -04:00
Jessie Nadler
4fe66f521d Use region to create and describe ECS resources 2019-10-03 15:12:05 -04:00
Mike Grima
60183b29c1
Merge pull request #2447 from bblommers/bugfix/2445
#2445 - DynamoDB - Add validation for AttributeDefinitions
2019-10-03 11:52:29 -07:00
Mike Grima
af48133ba5
Merge pull request #2448 from jthorniley/features/stepfunctions-fix-arn
Stepfunctions minor improvements
2019-10-03 11:50:37 -07:00
Mike Grima
567a6da31d
Merge pull request #2439 from Kerl1310/feature/send_templated_email
#2437 Implementing send_templated_email
2019-10-03 11:49:45 -07:00
Mike Grima
59de29f2ae
Merge pull request #2446 from yh1224/fix-#2444
trim invalid newline
2019-10-03 11:48:42 -07:00
Mike Grima
b9c1d5a91f
Merge pull request #2436 from yan12125/s3-copy-key-with-question-mark
Fix copying S3 objects with question marks in keys
2019-10-03 11:48:08 -07:00
Mike Grima
1cae78ad2f
Merge pull request #2435 from waynemetcalfe/issue-2432
Issue 2432
2019-10-03 11:47:13 -07:00
Mike Grima
c4b310d7a5 Adding support for querying AWS Config for supported configurations.
At this time, only adding support for S3.
2019-10-03 11:43:56 -07:00
Jim Shields
d8333fdd7e Add support for tagging of ECS services
* Add tags to create_service
* Add service to list_tags_for_resource
2019-10-03 14:30:08 -04:00
James Thorniley
31310760ea stepfunctions: start_execution accepts name arg 2019-10-03 14:47:24 +01:00
James Thorniley
7f33ec4420 correct description of error for invalid state machine arn 2019-10-03 14:14:06 +01:00
James Thorniley
33398d628f fix: iam role arn should have two colons 2019-10-03 14:00:33 +01:00
Bert Blommers
6005b19ac2 #2445 - DynamoDB - Add validation for AttributeDefinitions 2019-10-03 10:54:10 +01:00
Yoshiharu Hirose
570d3a9ee7 trim invalid newline 2019-10-03 17:04:49 +09:00
Ivan Dromigny
03986df929 Update syntax 2019-10-03 09:53:04 +02:00
Ivan Dromigny
83c8740b91 Add informations in subscriptions attributes 2019-10-02 18:06:34 +02:00
Kyle Jones
1d5140e11d Implementing send_templated_email 2019-10-02 08:39:35 +01:00
Chih-Hsuan Yen
6c0a2dc374
Fix copying S3 objects with question marks in keys
PR #2062 fixes copy for unicode keys. However, the change breaks keys
with question marks. Here is an alternative fix that works for both
emojis and question marks.

I notice this when running the test suite of aiobotocore. One of the
tests [1] is broken with moto >= 1.3.8.

[1] https://github.com/aio-libs/aiobotocore/blob/0.10.3/tests/test_basic_s3.py#L314-L329
2019-09-29 23:55:52 +08:00
Jack Danger
4497f18c1a
fixing ErrorResponse top-level tag (#2434)
In the golang SDK the previous format throws an unmarshaling error:

    /usr/local/Cellar/go/1.12.6/libexec/src/encoding/xml/read.go:209 &errors.errorString{s:"unknown error response tag, {{ Response} []}"}
    err: <*>SerializationError: failed to unmarshal error message
2019-09-27 11:14:53 -07:00
Wayne Metcalfe
9c66839f85 feat: implement logs untag_log_group 2019-09-26 20:20:53 +01:00
Wayne Metcalfe
0561a0050f feat: implement logs tag_log_group 2019-09-26 19:57:34 +01:00
Wayne Metcalfe
3cb7c3e568 feat: implement logs list_tags_log_group 2019-09-26 17:04:09 +01:00
Steve Pulec
23c1696b72
Merge pull request #2430 from jessevogt/handle-url-encoded-keys
Fix for #2431 delete objects fails with url encoded key
2019-09-25 20:55:42 -05:00
Steve Pulec
9cc6a1533f
Merge pull request #2409 from bblommers/feature/stepfunctions
Step Functions - basic method implementation
2019-09-24 18:16:07 -05:00
Jesse Vogt
3b4cd1c27b switch from calling clean in loop to undoing clean in delete_keys 2019-09-24 17:07:58 -05:00
Jesse Vogt
2df0309db5 unquote key name multiple times until stable value 2019-09-24 16:10:08 -05:00
Bert Blommers
38455c8e19 Step Functions - Remove STS-client and refer to hardcoded account-id 2019-09-24 14:36:34 +01:00
Steve Pulec
86fc340ffd
Merge pull request #2428 from mangin/get_log_events_problem
fix tail message problem in get_log_events
2019-09-23 21:44:36 -05:00
Steve Pulec
6795a219cd
Merge pull request #2417 from Gapex/fix-MaxKeys
MaxKeys limits the sum of folders and keys
2019-09-23 21:38:26 -05:00
Steve Pulec
cbe1ff1974
Merge pull request #2422 from kiyonori-matsumoto/dynamodb-and-order
fix: raises ValueError on conditional and operator
2019-09-23 21:35:08 -05:00
Aleksandr Mangin
b163f23a22 fix tail message problem in get_log_events 2019-09-23 18:35:44 +02:00
Gapex
1c36e1e2c5 update unit test and fix StartAfter 2019-09-17 10:42:10 +08:00
Kiyonori Matsumoto
7ee35a8510 fix: raises ValueError on conditional and operator
if lhs evaluates to false, rhs must be ignored, but rhs was evaluated then ValueError is occurred.
2019-09-16 23:33:52 +09:00
Gapex
4946f8b853 'lint' 2019-09-16 15:31:57 +08:00
Gapex
59f87e30ba split truncated keys by type 2019-09-16 15:20:24 +08:00
Gapex
47635dc82e update key of sort 2019-09-16 13:33:53 +08:00
Gapex
a36b84b3aa fix MaxKeys in list_objects_v2 2019-09-16 11:35:36 +08:00
mattsb42-aws
4f34af95bc remove dead code
because the key ID validation is now centralized,
by the time this code would have been reached,
we know that the key ID exists,
so a KeyError will never be thrown
2019-09-13 13:35:55 -07:00
mattsb42-aws
a2c2a83198 fix linting issues 2019-09-12 18:04:18 -07:00
mattsb42-aws
f4c5dfbdfb reorganize and centralize key ID validation 2019-09-12 17:42:40 -07:00
Jessie Nadler
2b8bdc9bca Validate elbv2 FixedResponseConfig attributes 2019-09-12 12:29:03 -04:00