Commit Graph

84 Commits

Author SHA1 Message Date
Matěj Cepl
77dc60ea97 Port test suite from nose to pytest.
This just eliminates all errors on the tests collection. Elimination of
failures is left to the next commit.
2020-11-10 08:23:44 +01:00
usmangani1
19fc76f466
Fix: SNS Delete subscriptions on topic deletion (#3410)
* Fix:Delete subscriptions on delete topic

* Changed tests

Co-authored-by: usmankb <usman@krazybee.com>
2020-10-29 08:52:02 +00:00
Brian Pandola
28c1690fc2
Add Support for SNS Topic KmsMasterKeyId Attribute (#3389)
We do not do any validation of the `KmsMasterKeyId` attribute, and simply
store it as-as.  This mimics the behavior in AWS, where the key is not
validated until it is actually used (when publishing[1]).

[1]: https://docs.aws.amazon.com/sns/latest/dg/sns-server-side-encryption.html

Closes #3216
2020-10-16 12:30:07 +01:00
usmangani1
a65c0f004c
Fix:SQS Receive Message (MessageAttributes) in response (#3303)
* Fix:SQS Receive Message (MessageAttributes) in response

* Fixed tests

Co-authored-by: usmankb <usman@krazybee.com>
2020-10-05 10:10:24 +01:00
Karthikeyan Singaravelan
7054143701
Fix deprecation warnings due to invalid escape sequences. (#3273)
* Fix deprecation warnings due to invalid escape sequences.

* Fix linter error.
2020-09-10 09:20:26 +01:00
Daniel Okey-Okoro
c321ad46b0
fix: deleting non-existent topic shouldn't raise KeyError (#3285) 2020-09-10 08:32:41 +01:00
Kamil Mańkowski
8a551a9754
[SNS] Mock sending directly SMS (#3253)
* [SNS] Mock sending directly SMS

Proper behaviour when publishing to PhoneNumber is sending
message directly to this number, without any topic or
previous confirmation.

https://docs.aws.amazon.com/sns/latest/dg/sns-mobile-phone-number-as-subscriber.html

* Fix arguments order

* Omit checking local backend when tests in server mode
2020-08-25 13:05:49 +01:00
gruebel
23dfecc845 Fix missing MessageAttributes when using RawMessageDelivery 2020-03-21 19:25:25 +01:00
Asher Foa
d9d055c75d Fix more typos. 2020-01-23 10:15:02 -08:00
gruebel
2fb5004dc2 Fix sns unsubscribe & delete_topic behavior 2019-12-27 16:04:12 +01:00
Mike Grima
91983b4823
Merge pull request #2610 from gruebel/fix-sns-get-subscription-attributes
Add missing attributes to SNS subscription
2019-12-17 08:36:59 -08:00
Fabio Dias
743dd46399 black linting 2019-12-16 21:25:20 -05:00
Fabio Dias
fd9ac4b9a5 ACCOUNT_ID moved to moto.core, MOTO_ACCOUNT_ID env var override 2019-12-16 21:05:29 -05:00
Fabio Dias
b83a750630 Added references to moto.iam.models.ACCOUNT_ID instead of hardcoded id 2019-12-16 19:56:11 -05:00
gruebel
deaeef521b Add missing attributes to SNS subscription 2019-11-30 15:51:43 +01:00
gruebel
3d5d477f7f Fix sns.publish with number type and 0 value 2019-11-16 14:46:05 +01:00
gruebel
58daa428f3 Fix sns.subscribe validation for sms numbers 2019-11-04 22:57:53 +01:00
Asher Foa
96e5b1993d Run black on moto & test directories. 2019-10-31 10:36:05 -07:00
gruebel
6b7294a018 Fix sns.add_permission & remove_permission 2019-10-25 17:57:50 +02:00
Mike Grima
4da9ec1346
Merge pull request #2442 from titibike/sns_subscription_attributes
Issue #2441 Add informations in SNS subscriptions `attributes`
2019-10-15 10:05:20 -07:00
Ivan Dromigny
123209515c Change test 2019-10-15 16:12:22 +02:00
Ivan Dromigny
02fc1fbcef Add a test 2019-10-14 18:03:01 +02:00
gruebel
26ef792690 Add sns.untag_resource 2019-10-12 21:10:51 +02:00
gruebel
726775678c Add sns.tag_resource 2019-10-12 20:37:59 +02:00
gruebel
8d527743d5 Add sns.list_tags_for_resource 2019-10-11 17:58:48 +02:00
gruebel
d8a922811c Add exact Number, exact String.Array and attribute key matching to SNS subscription filter policy and validate filter policy 2019-08-25 21:08:02 +02:00
Berislav Kovacki
7e863b0260 Add attributes parameter support for sns create_topic API 2019-02-21 22:08:46 +01:00
Michael Bell
51db19067c Allow attributes to be set with subscribe command (#1705) 2018-07-13 10:21:33 +01:00
Iain Bullard
cd4dd3cfbf SNS - Enforce 'Message too long' exception when publishing messages 2018-06-04 13:38:58 +00:00
hsuhans
d9a4501d24 Change SNS http header to actual setting 2018-06-02 06:18:27 +08:00
Steve Pulec
b6909ff64c
Merge pull request #1654 from Birne94/sns-raw-message-delivery
Add RawMessageDelivery for SNS subscriptions (fixes #1571)
2018-05-30 09:46:59 -04:00
Daniel Birnstiel
222cb1535c Add RawMessageDelivery for SNS subscriptions (fixes #1571) 2018-05-30 09:30:18 +02:00
Ben Jolitz
45b529fef4 parameterize topic name create/delete 2018-05-04 19:17:56 -07:00
wblackconv
ba2ea8e1b3 Add tests for message attribute validation in SNS (#1582)
* Add tests for message attribute validation in SNS

Fixes up bug in return value of
moto.sns.responses.SNSResponse._parse_message_attributes due to
accidental recycling of a variable.

* Fix test_sns.test_publish_to_http in py36 env

Http response is encoded as a byte string which json.loads can't handle.
2018-04-27 15:10:30 -07:00
wblack
0b36f06df1 Fixes for linter warnings 2018-04-18 13:42:36 +00:00
wblack
f401c60825 Include SNS message attributes with message body when delivering to SQS. 2018-04-18 13:42:36 +00:00
Steve Pulec
cd1c6d3e6c Unvendor responses, move back to upstream. 2018-04-05 16:57:43 -04:00
Iain Bullard
d3d9557d49 Implement basic SNS message filtering (#1521)
* Add support for FilterPolicy to sns subscription set_filter_attributes

* Add basic support for sns message filtering

This adds support for exact string value matching along with AND/OR
logic as described here:

https://docs.aws.amazon.com/sns/latest/dg/message-filtering.html

It does not provide support for:
- Anything-but string matching
- Prefix string matching
- Numeric Value Matching

The above filter policies (if configured) will not match messages.
2018-03-21 08:49:11 -07:00
Boris Gvozdev
633decc6c0 SNS: do not duplicate subscriptions 2018-01-02 11:30:39 +11:00
Alexander Mohr
9d087b0729 add subject support (#1387) 2017-12-10 21:59:04 +00:00
Adam Gilman
2ad0f2fc1c SNS create_topic should only accept valid characters (#1329)
* SNS create_topic should only accept valid characters

Closes #1328

* Fix flake8 errors

* Updated regex to match full TopicName constraints

Fixed test_server as it contained invalid TopicNames’ per constraints

* fix error message for invalid topic name
2017-11-13 18:27:11 +00:00
Adam Gilman
307ef8ead1 Makes Creating SNS topics idempotent (#1324)
Make creating SNS topics idempotent

Closes #1323
2017-11-06 19:06:55 +00:00
Terry Cain
dce81cf875 Fixed typos ;-)
Thanks @hwine
2017-10-20 14:52:24 +01:00
Terry Cain
bca8e11290 Fixes #1276 SNS Subject validation 2017-10-20 13:19:55 +01:00
Terry Cain
56c65bc67c
Added in publish by phone number 2017-09-26 00:21:07 +01:00
Terry Cain
18cb0bce54
General tidy up 2017-09-21 21:16:00 +01:00
Terry Cain
19074c535c
Added ConfirmSubscription + Tests + checks
For now subscriptions do nothing, but if we go the route of handing out subscribe tokens, I
have layed the groundwork for validating that
2017-09-20 21:47:02 +01:00
Terry Cain
ef8a97f6c3
Implemented Add/RemovePermission + Tests 2017-09-20 21:13:26 +01:00
Terry Cain
f7f80293c7
Implemented OptInPhoneNumber + Tests 2017-09-20 20:56:37 +01:00
Terry Cain
1281ac86d5
Implemented ListPhoneNumbersOptedOut + Tests 2017-09-20 00:03:58 +01:00