Commit Graph

2454 Commits

Author SHA1 Message Date
Mike Grima
921b5a3227 Fixing broken tests #2126
- KMS
- S3
- CloudFormation (Thanks kgutwin!)
2019-03-28 10:09:03 -07:00
Mike Grima
64152f4cda
Merge pull request #2073 from woohooyayaya/master
fix creation date in create key response to unix timestamp type
2019-03-11 15:58:19 -07:00
Mike Grima
6ecb840c61
Merge pull request #2100 from gilbsgilbs/non-versioned-bucket-consitency
[S3] Support null version ids for buckets with versioning disabled
2019-03-11 14:13:26 -07:00
Mike Grima
53b94606de
Merge pull request #2103 from mikegrima/config
Fixed validation bugs in put_configuration_recorder
2019-03-11 13:58:54 -07:00
Mike Grima
87a54b9d81
Merge pull request #2077 from markchalloner/mark-route53-upsert-type
Check record type when upserting.
2019-03-11 13:50:37 -07:00
Mike Grima
fe42309534
Merge pull request #2096 from tay-bird/fix-describe-volumes-response-with-no-tags
Fix describe volumes response with no tags
2019-03-11 13:44:15 -07:00
Mike Grima
6d67418c41 Fixed validation bugs in put_configuration_recorder 2019-03-11 13:25:36 -07:00
Gilbert Gilb's
dedb53371e [S3] Support null version ids for buckets with versioning disabled 2019-03-09 10:21:49 +01:00
Tay Frost
7b236c4ded bugfix ebs volume tag behaviour
This commit modifies the response format of the ec2 calls
`create_volume` and `describe_volumes`. Previously, these calls would
always include a `Tags` key in the response, even when a volume has no tags.
Now, the `Tags` key will not be included in the response if the volume
has no tags.

When an EBS volume has no tags, calls to the aws ec2 endpoints `create_volume`
and `describe_volumes` do not include the `Tags` key in the
`response.Volumes[]` object.

However, moto does include the `Tags` key in this case. This discrepancy
in behaviour can result in code passing a moto test but failing in
production.

Sample snippets that trigger this condition:

```
def create_volume_and_then_get_tags_from_response():
    client = boto3.client('ec2', region_name='us-east-1')
    volume_response = client.create_volume(
        Size=10,
        AvailabilityZone='us-east-1a'
    )
    keys = volume_response['Keys']
```

```
def create_volume_and_then_get_tags_from_describe_volumes():
    client = boto3.client('ec2', region_name='us-east-1')
    volume_response = client.create_volume(
        Size=10,
        AvailabilityZone='us-east-1a'
    )
    volume_describe_response = client.describe_volumes()
    keys = volume_describe_response['Volumes'][0]['Keys']
```

Both sample snippets will succeed in a moto test, but fail with a
`KeyError` when using the aws api.
2019-03-07 17:31:45 -05:00
Mike Grima
d6022417f5 Forgot to add Config to the __init__.py. 2019-03-07 12:53:01 -08:00
Mike Grima
7eaf6bf595
Merge pull request #2062 from domtes/fix_copy_key_with_unicode
Fixing S3 copy_key error when using unicode.
2019-03-04 11:48:46 -08:00
Mike Grima
9158c1356f
Merge pull request #2091 from whummer/fix/dict-sorted
Fix sorting of log groups
2019-03-04 11:04:42 -08:00
Mike Grima
848a4f451e
Merge pull request #2087 from mikegrima/config
Basic AWS Config service support.
2019-03-04 11:04:12 -08:00
Domenico Testa
74ff2ccc95 Reformatting to get better coverage results 2019-03-04 09:16:43 +01:00
Mike Grima
bc116ab750 Basic AWS Config service support. 2019-03-02 18:37:20 -08:00
Waldemar Hummer
840045c688 fix sorting of log groups 2019-03-02 18:56:49 -05:00
Mark Challoner
d61ce0584b
Check record type when upserting.
Previously this was not checked so an existing record (e.g. with type A) would be overwritten on upsert by a record with the same name but different type (e.g. TXT).

This commit also:

* publicizes the type variable appending the underscore affix (required to maintain compatibility with CloudFormation which sets type as the CF type),
* fixes a wrong assumption in tests that UPSERT applies a change to Type (it creates a distinct record instead),
* Updates ACM model to use serial_number instead of deprecated and remove serial causing Travis failures.
2019-03-01 16:44:50 +00:00
Chih-Hsuan Yen
9992e23e68
Fix compatibility with cryptography 2.6
[1] https://github.com/pyca/cryptography/blob/master/CHANGELOG.rst#26---2019-02-27
2019-03-01 19:22:26 +08:00
woohooyayaya
e6e7f235ac
fix creation date in create key response to unix timestamp type 2019-02-25 16:14:24 -08:00
Mike Grima
09855801ba
Merge pull request #2019 from acsbendi/launch_index
Correctly returning ami launch index
2019-02-25 12:16:40 -08:00
Mike Grima
3920f0e16b
Merge pull request #2060 from gregsterin/better-support-for-ddb-expressions
support a bit more of the dynamoDB ConditionExpression syntax
2019-02-25 10:03:02 -08:00
William Rubel
a5208222b4 Fixing list entities for policy 2019-02-18 21:29:09 -06:00
William Rubel
59deb4d6c0 Fixing list entities for policy 2019-02-18 21:25:29 -06:00
William Rubel
e9d8021c86 Fixing list entities for policy 2019-02-18 21:20:29 -06:00
William Rubel
ce7b5ebf54 Fix policy date 2019-02-17 21:37:33 -06:00
William Rubel
63b692356d Fix policy date 2019-02-17 16:49:54 -06:00
William Rubel
9e9e37eb62 Add test for roles 2019-02-17 15:35:49 -06:00
William Rubel
31258e9e9e Add test for roles 2019-02-17 15:23:59 -06:00
William Rubel
37cb5ab4e6 Add test for roles 2019-02-17 14:36:53 -06:00
William Rubel
921a993330 cleaning up files 2019-02-17 14:30:43 -06:00
William Rubel
8ad28f8400 Adding additional tests to increase coverage 2019-02-16 20:53:27 -06:00
William Rubel
5372e6840f Increasing code coverage 2019-02-16 12:37:46 -06:00
Domenico Testa
6897a118ed Fixing S3 copy_key error when using unicode. 2019-02-16 16:42:00 +01:00
William Rubel
0a3ff94e66 Update kms and lambda to work with terraform 2019-02-16 09:37:27 -06:00
William Rubel
4c6f08d463 Update kms and lambda to work with terraform 2019-02-16 09:27:23 -06:00
Greg Sterin
c1232a7a23 linting 2019-02-15 13:49:42 -08:00
Greg Sterin
f035b9613d support a bit more of the dynamoDB ConditionExpression syntax 2019-02-14 18:10:01 -08:00
Mike Grima
94672799cf Fixed a bug in get_account_authorization_details for attached managed policies.
Fixed a bug in the XML template for `get_account_authorization_details` where attached managed policies
were empty strings.
2019-02-07 17:32:31 -08:00
Mike Grima
f41c4e756f
Merge pull request #2041 from mikegrima/roletags
IAM Role Tagging support
2019-02-06 11:40:59 -08:00
Mike Grima
dfceab9bf0 Some fixes to get_account_authorization_details 2019-02-04 13:44:01 -08:00
Mike Grima
142fc65260
Merge pull request #2014 from garyd203/dynamodb-set-comparison
Make EQ conditions on sets work reliably in DynamoDB
2019-02-01 11:49:48 -08:00
Mike Grima
d652755f3b
Merge pull request #2032 from drmorr0/spot_fleet_tag_specifications
tag specifications for spot fleet requests
2019-02-01 11:47:36 -08:00
Mike Grima
8d17271ee4
Merge pull request #2028 from acsbendi/network-acl-fixes
Network ACL fixes
2019-02-01 11:46:25 -08:00
Mike Grima
536d8c8457
Merge pull request #1909 from markchalloner/cf-list-change-sets
Add CloudFormation methods describe_change_set and list_change_sets.
2019-01-31 17:47:32 -08:00
Mike Grima
1a36c0c377 IAM Role Tagging support 2019-01-31 17:37:26 -08:00
William Richard
935039d684
ECR now uses api.ecr as its endpoint.
This changed in botocore 1.12.85. See b5fa8a5139

This fixes https://github.com/spulec/moto/issues/2035
2019-01-25 14:47:23 -05:00
David Morrison
b4b63202d9 tag specifications for spot fleet requests 2019-01-24 11:38:07 -08:00
Mark Challoner
337601b5fb
Add CloudFormation methods delete_change_set, describe_change_set and list_change_sets. 2019-01-21 17:18:50 +00:00
acsbendi
68b8e6b636 Implemented adding default entries to default network ACLs. 2019-01-21 15:36:49 +01:00
acsbendi
3c5ce6c09e Fixed new subnets associated with a network ACL from a different VPC. 2019-01-21 13:30:22 +01:00