Commit Graph

1935 Commits

Author SHA1 Message Date
Juan Martinez
ed93821621 Set ECR imagePushedAt to current date and time (#2229) 2019-06-06 13:34:10 +01:00
Elliott Butler
9bd15b5a09
Fix route53 alias response.
This commit
* includes the work by @elliotmb in #1694,
* removes the AliasTarget.DNSName copy into a RecordSet.Value,
* fixes and adds tests.
2019-05-31 10:54:18 +01:00
Juan Martinez
664b27d8e7 Implement ECR batch_delete_image (#2225)
This implements the endpoint in spulec #2224
2019-05-30 18:16:19 +01:00
Bendegúz Ács
8f53b16b9a Updates to create_subnet and describe_subnets responses (#2053)
* Removed Tags field from create_subnet response.

* Added DefaultForAz to create_subnet response.

* Added MapPublicIpOnLaunch to create_subnet response.

* Added OwnerId to create_subnet response.

* Added AssignIpv6AddressOnCreation field for create_subnet and describe_subnet and implemented setting it in modify_subnet_attribute.

* Added SubnetArn to create_subnet response.

* Added AvailabilityZoneId to create_subnet and describe_subnet responses, and error for invalid availability zone.

* Added Ipv6CidrBlockAssociationSet to create_subnet response.

* Added missing fields to describe_subnets response.

* Added myself to list of contributors and marked describe_subnet as implemented.

* Fixed linting errors.

* Fixed blank line containing a tab.

* Fixed accidentally deleted ).

* Fixed broken tests.
2019-05-28 16:33:25 +01:00
A
2386d47fe3 SecretsManager secret value binary support (#2222) 2019-05-28 16:32:43 +01:00
Bendegúz Ács
21917c4b93 Bug fix for default network ACL entries (#2056)
* Fixed a bug where default network ACL entries could not be deleted.

* Implemented throwing error when a network entry with the same rule number and egress value already exists.

* Fixed syntax errors.

* Added socket.timeout to possibly raised exceptions in wait_for for Python 3.
2019-05-26 02:02:14 +01:00
Alexander Mohr
7271fb9391 Fix S3 backend operations with VersionId (#2055)
* fix s3 issues

* fix merge conflict

* fix and add test cases
2019-05-25 20:19:33 +01:00
Bendegúz Ács
f408709ef9 VPC IPv4 validation (#2026)
* Implemented throwing invalid subnet range error and fixed breaking tests.

* Implemented throwing invalid CIDR block parameter error for vpcs and subnets.

* Implemented throwing invalid destination CIDR block error.

* IPv6 addresses not accepted, strict checking disabled.

* Implemented throwing invalid subnet conflict error and fixed breaking tests.

* Implemented throwing invalid VPC range error and fixed breaking tests.

* Fixed accidentally removed ).

* Fixed test case trying to create two subnets with the same CIDR range.
2019-05-25 18:35:07 +01:00
Garrett
c739c5331e Handle UnicodeEncodeError when parsing querystring (#2170) 2019-05-25 18:34:47 +01:00
Adam Hodges
71f83d7e4f Add support for IoT register_certificate (#1827) 2019-05-25 18:30:23 +01:00
Jordan Sanders
4cce4defac Support CustomAmiId in EMR (#2037) 2019-05-25 11:19:26 +01:00
Gregory Bataille
d952410965 1987 support transfer acceleration (#2018)
* chore(): remove executable flag on moto/s3/response.py

* chore(): ignore .eggs temp file

* feat(#1987): get bucket acceleration support

* feat(#1987): put bucket acceleration support

* feat(#1987): suspend undefined bucket is a no-op

* feat(#1987): validate accelerate_configuration status

* feat(#1987): bucket containing dots do not support acceleration

* doc(#1987): update implementation coverage
2019-05-25 11:19:00 +01:00
William Richard
1b91534165 Add support for redirect actions on ELBv2 listeners (#2029) 2019-05-25 11:18:39 +01:00
David
868d0107bf Autoscaling instance azs (#2030)
* Add instance AZ support in autoscaling

* Resolve py36-py27 format string error in test_autoscaling
2019-05-25 11:18:16 +01:00
Daniel Miranda
fb2a76fd66 ec2: add support for creation and importing of real SSH keys (#2108)
* ec2: add support for creation and importing of real SSH keys

* setup: lock PyYAML version to avoid incompatibilities
2019-05-25 11:17:52 +01:00
Mark Challoner
d8ff67197b Add resource-groups. (#1953) 2019-05-25 11:10:34 +01:00
Don Kuntz
238d1c7c39 Add glue.delete_table endpoint, for allowing tables to be deleted (#2112)
* Add glue.delete_table endpoint, for allowing tables to be deleted

* remove extra whitespace
2019-05-25 10:58:41 +01:00
Jeffery Smith
4a99dcddb2 Issue #2141 Adding owner-id to the filter for Snapshot (#2142)
* Adding owner-id to the filter for Snapshot
2019-05-25 10:34:59 +01:00
Hans
9b12ce6809 Fix #1842 Create cross region VPC peering connection in both region (#2195)
Add a class level store in models/VPCPeeringConnectionBackend of ec2
for saving vpc peering connection.
Any instance can correctly save VPC peering connection info
on both region when it create vpc peering connection.

Update vpc_peering_connections in ec2/responses to meet new version:
DESCRIBE_VPC_PEERING_CONNECTIONS_RESPONSE,
ACCEPT_VPC_PEERING_CONNECTION_RESPONSE,

Previous code only create one region VPC peering connection but
doesn't create the other region VPC peering connection
when create cross region VPC peering connection.

Tested in real AWS environment at first
and create unit test case according to real AWS environment response.

Add 5 test cases
VPC cross region delete case
VPC cross region accept case
VPC cross region accept wrong region case
VPC cross region reject case
VPC cross region reject wrong region case

Related: #1842, #1830
2019-05-25 10:21:57 +01:00
Ashley Gould
a3f6d2c110 [Resolves #2196] - endpoints for querying organizations SC policies (#2197)
adding support for organizations service control policies

* [Resolves #2196] - endpoints for querying organizations SC policies

I have added the following mock endpoints to the Organizations service:

- create_policy
- list_policies
- describe_policy
- attach_policy
- list_policies_for_target
- list_targets_for_policy
2019-05-25 10:20:19 +01:00
Koudai Aono
a61124f774 support to create dynamodb resource by cloudformation (#2219)
* support to create dynamodb resource by cloudformation
2019-05-25 10:16:33 +01:00
Jon Beilke
cb72d1d00e Feature cloudwatch log retention (#2199)
* add proper retentionInDays to describe_log_groups response and add support for delete_retention_policy() and put_retention_policy() to log groups

* fix for inline comment formatting

* include check for retentionInDays to verify no retention by default in  test_log_group_create
2019-05-25 10:14:23 +01:00
Dan Chan
2a5f7e15a7 Updating redshift.describe_cluster_snapshots to return multiple snapshots for cluster_identifier (#2216) 2019-05-23 09:01:47 +01:00
Ber Zoidberg
1088c421d2 #2212 add support for delete on update_with_attribute_updates (#2213)
* add support for delete on update_with_attribute_updates
2019-05-22 10:47:02 +01:00
Justin Kieber-King
bbd7fefb37 Feature: Secrets Manager put_secret_value and list_secret_version_ids (#2116)
* initial work

- adding put_secret_value and list_secret_versions

* Added support for versions in all functions except rotate_secret

* more work

- refactor rotate_secret method
  - now, adds a new version of the secret and points default version id to it
- updated implementation coverage readme
- element in list check to fix unit test
- fixed linting errors
- added tests, fixed exception, failing tests still
- secrets_manager/test_server fails when running whole suite,
  but not when running that individual test file

* fixed failing test_get_secret_value

* Removed test.py. Fixed condition statement.

* fixed default stages + adding AWSPREVIOUS

* remove old AWSPREVIOUS stages
2019-05-22 10:45:22 +01:00
cm-iwata
8f4c273095 fix #2190 (#2194)
lambda list_versions_by_function return $LATEST version and published version
2019-05-21 17:49:56 +01:00
James Bungard
796dd71c0c Platform independent KMS timestamp generation (#2193)
* Platform independent KMS timestamp generation

Fixes #2192

* Switch to moto.core.unix_time

Fixes #2192
2019-05-21 17:46:22 +01:00
cm-iwata
9bf8fd3417 fix #2011 (#2012)
add support for Scan method using LSI or GSI
2019-05-21 17:45:30 +01:00
Travis Truman
b8ba7980a0 Adding support for specifying a PermissionsBoundary ARN in calls to i… (#2182)
* Adding support for specifying a PermissionsBoundary ARN in calls to iam.create_role

Closes #2181

* Correcting whitespace error

* Adding support for Role PermissionsBoundary to be returned from
calls to list_roles

* Raise ClientError when a bad permissions boundary ARN is supplied
2019-05-21 17:44:05 +01:00
Craig Anderson
33efe07b43 Hide CloudFormation pararamters with NoEcho. Fixes #2021 (#2024) 2019-05-21 00:05:02 +01:00
Alexey Firsov
f13e4e41cd add implemented kinesis method describe_stream_summary (#2023) 2019-05-21 00:02:36 +01:00
Jordan
1de9acb7ad Add cognito-idp admin_update_user_attributes #2184 (#2185) 2019-05-20 23:58:10 +01:00
redspart
1fd71fd45a Updated delete_cluster() for redshift (#2186)
* Updated the deprecated decorator to allow the "SkipFinalClusterSnapshot" option that aws supports.

* FIxed logical mistake on the delete_cluster

* Removed an unused exception I put in
2019-05-20 23:56:23 +01:00
Kyle Decot
8cb4db1896 Adds Support for filtering on schedulingStrategy in ECS#list_services (#2180) 2019-05-02 19:00:28 +01:00
Mike Grima
1cb208580d
Merge pull request #2027 from ralewis85/fix-request-id
Fix sending the Request ID in the response body
2019-04-30 09:34:23 -07:00
shiba24
b822db8d8c Support create_table with PAY_PER_REQUEST billing mode of DynamoDB 2019-04-30 22:36:25 +09:00
Terry Cain
4a286c4bc2
KMS generate_data_key (#2071)
* Added KMS.generate_data_key and KMS.generate_date_key_without_plaintext

Increase test coverage to cover Key not found

* Added test for kms.put_key_policy key not found
2019-04-26 20:52:24 +01:00
Mike Grima
603f7c58a2
Merge pull request #2166 from chriskilding/feature/secretsmanager-restoresecret
Feature: Secrets Manager restore-secret
2019-04-26 09:50:02 -07:00
Christopher Kilding
55fe629112 Feature: Secrets Manager restore-secret 2019-04-24 10:03:04 +01:00
Steve Pulec
88e1f0fa23
Merge pull request #2015 from corrjo/master
#1514 Stackset Support
2019-04-22 19:04:47 -05:00
Mike Grima
2fec1be1a2
Merge pull request #2160 from copland/fix-role-arn-slash
Add test to verify create_role path defaults to /
2019-04-22 09:58:41 -07:00
Chris Opland
dd898add4d Add test verifying create_role path defaults to / 2019-04-21 18:29:36 -05:00
Mike Grima
734a39b3e4
Merge pull request #2162 from cm-iwata/fix_dynamo_query
fix #2161 DyanmoDB query method using GSI with range key
2019-04-19 10:04:04 -07:00
Tomoya Iwata
431269bcd0 fix #2161
mock_dynamodb2 query fails when using GSI with range key if target table has record that have no range key attribute
2019-04-19 12:23:06 +09:00
Chris Kilding
8f21272e57 Use pytz instead of timezone 2019-04-18 17:27:13 +01:00
Chris Kilding
bd8aa341f2 Also throw exception if client tries to RotateSecret on a soft-deleted secret 2019-04-18 16:47:15 +01:00
Chris Kilding
749f4f63e6 Allow soft deletion of secrets 2019-04-18 15:44:48 +01:00
Chris K
fc8cf2d872 Feature: AWS Secrets Manager delete-secret 2019-04-18 10:30:18 +01:00
Mike Grima
97408552a3
Merge pull request #2033 from r1b/feat/cognitoidp-add-update-identity-provider
[cognitoidp] feat: add update_identity_provider
2019-04-17 12:21:45 -07:00
Mike Grima
65525cb611
Merge pull request #2114 from cm-iwata/fix_lambda_publish_version
Fix lambda publish_version returns wrong status code
2019-04-17 11:14:03 -07:00
Mike Grima
5d955985b9
Merge pull request #2106 from andytumelty/iam-update-user
Add support for iam update_user
2019-04-17 11:13:14 -07:00
Mike Grima
51ef03b03b
Merge pull request #2133 from earlrob/add_keyid_to_kms_encrypt_and_decrypt
add KeyId value to kms.responses.encrypt and kms.responses.decrypt
2019-04-17 11:07:00 -07:00
Mike Grima
d8dbc6a49c
Merge pull request #2134 from ogckw/master
Fix #2129 EC2 tag should raise ClientError when resource is empty
2019-04-17 11:05:28 -07:00
Mike Grima
53f101774f
Merge pull request #2137 from devoto13/fix-missing-version-id
Fixed copy-object from unversioned bucket to versioned bucket
2019-04-17 11:04:15 -07:00
Mike Grima
c7dc09345a
Merge pull request #2143 from chriskilding/feature/secretsmanager-listsecrets
Feature: aws secretsmanager list-secrets
2019-04-17 11:03:19 -07:00
Santosh Ananthakrishnan
4f1a1a9d1e [iam] create_policy_version: Fix version id calculation
When creating a new IAM policy version with create_policy_version,
we cannot use the length of the versions list to calculate VersionId.
Keep track of the next version id to use as a non-decreasing counter.

Fixes #2157
2019-04-16 20:15:57 +00:00
Chris K
89e4ab93ee Implement ListSecrets 2019-04-05 13:33:28 +01:00
Yaroslav Admin
b85d21b8fe Fixed copy-object from unversioned bucket to versioned bucket
The response of the copy-object operation was missing VersionId property
when source bucket is not versioned.
2019-04-02 15:30:01 +02:00
Steve Pulec
66dafc6679
Merge pull request #2130 from spulec/bugfix/network-interface-and-private-ip
Add private IP to every NetworkInterface
2019-04-01 15:17:36 -05:00
hsuhans
6b7282f93c Fix #2129 EC2 tag should raise ClientError when resource is empty
Raise MissingParameterError exception in models/validate_resource_ids of ec2.

Add ec2 create tag with empty resource test case.
Add ec2 delete tag with empty resource test case.

Related: #2129

Reference
boto3 create_tags
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2.html#EC2.Client.create_tags

boto3 delete_tags
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2.html#EC2.Client.delete_tags

Amazon EC2 API Reference Actions CreateTags
https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_CreateTags.html

Amazon EC2 API Reference Actions DeleteTags
https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DeleteTags.html
2019-03-30 23:26:50 +08:00
Earl Robinson
dbdc8925e3 add KeyId value to kms.responses.encrypt and kms.responses.decrypt 2019-03-29 21:07:32 -04:00
Tomoya Iwata
52ad71879d modified test code for python2.7 2019-03-29 15:52:47 +09:00
Tomoya Iwata
7e28fa7bfe Merge branch 'master' into fix_lambda_publish_version 2019-03-29 09:52:47 +09:00
Nick Venenga
d181897ec9
Add proper failure response to describe_clusters 2019-03-28 14:50:48 -04:00
Mike Grima
921b5a3227 Fixing broken tests #2126
- KMS
- S3
- CloudFormation (Thanks kgutwin!)
2019-03-28 10:09:03 -07:00
Hugo Lopes Tavares
7c62f4a75c Add test to CloudFormation and PrimaryPrivateIpAddress GetAtt
This test would raise an error before d4e39146b7
2019-03-27 16:28:18 -04:00
Hugo Lopes Tavares
d4e39146b7 Make sure every NetworkInterface has a private IP
AWS always assigns a primary IP address to Network Interfaces.
Using a test account (modified the IP):

    >>> import boto
    >>> vpc = boto.connect_vpc()
    >>> eni = vpc.create_network_interface(subnet_id)
    >>> eni.private_ip_addresses
    [PrivateIPAddress(10.1.2.3, primary=True)]
2019-03-27 16:27:10 -04:00
Tomoya Iwata
11ff548d14 fix #2113
moto must return Http status code 201 when lambda publish_version has succeeded
2019-03-17 17:54:34 +09:00
Robert Jensen
9ed80f14e8 fix coverage, update IMPLEMENTATION_COVERAGE 2019-03-12 17:52:34 -04:00
Robert Jensen
c7d3e1f8b6 Merge remote-tracking branch 'upstream/master' into feat/cognitoidp-add-update-identity-provider 2019-03-12 17:37:07 -04:00
Andy Tumelty
d53626ad9a Add support for iam update_user
This covers both the NewPath and NewUserName parameters for update_user, but
without regex validation for these values.
2019-03-12 17:23:32 +00:00
Mike Grima
6ecb840c61
Merge pull request #2100 from gilbsgilbs/non-versioned-bucket-consitency
[S3] Support null version ids for buckets with versioning disabled
2019-03-11 14:13:26 -07:00
Mike Grima
53b94606de
Merge pull request #2103 from mikegrima/config
Fixed validation bugs in put_configuration_recorder
2019-03-11 13:58:54 -07:00
Mike Grima
87a54b9d81
Merge pull request #2077 from markchalloner/mark-route53-upsert-type
Check record type when upserting.
2019-03-11 13:50:37 -07:00
Mike Grima
6d67418c41 Fixed validation bugs in put_configuration_recorder 2019-03-11 13:25:36 -07:00
Gilbert Gilb's
dedb53371e [S3] Support null version ids for buckets with versioning disabled 2019-03-09 10:21:49 +01:00
stephane soulier
fa3fd729d1 fix bug in Stream init (wrong number of shards) 2019-03-08 16:27:24 +01:00
Tay Frost
15b3ede3cc Add test for case where ebs volume has no tags.
This commit adds a test for a case where an EBS volume has no tags. When
an EBS volume has no tags, calls to the aws ec2 endpoints `create_volume`
and `describe_volumes` do not include the `Tags` key in the
`response.Volumes[]` object.

However, moto does include the `Tags` key in this case. This discrepancy
in behaviour can result in code passing a moto test but failing in
production.

Sample snippets that trigger this condition:

```
def create_volume_and_then_get_tags_from_response():
    client = boto3.client('ec2', region_name='us-east-1')
    volume_response = client.create_volume(
        Size=10,
        AvailabilityZone='us-east-1a'
    )
    keys = volume_response['Keys']
```

```
def create_volume_and_then_get_tags_from_describe_volumes():
    client = boto3.client('ec2', region_name='us-east-1')
    volume_response = client.create_volume(
        Size=10,
        AvailabilityZone='us-east-1a'
    )
    volume_describe_response = client.describe_volumes()
    keys = volume_describe_response['Volumes'][0]['Keys']
```

Both sample snippets will succeed in a moto test, but fail with a
`KeyError` when using the aws api.
2019-03-07 17:25:18 -05:00
Mike Grima
7eaf6bf595
Merge pull request #2062 from domtes/fix_copy_key_with_unicode
Fixing S3 copy_key error when using unicode.
2019-03-04 11:48:46 -08:00
Mike Grima
bc116ab750 Basic AWS Config service support. 2019-03-02 18:37:20 -08:00
Mark Challoner
d61ce0584b
Check record type when upserting.
Previously this was not checked so an existing record (e.g. with type A) would be overwritten on upsert by a record with the same name but different type (e.g. TXT).

This commit also:

* publicizes the type variable appending the underscore affix (required to maintain compatibility with CloudFormation which sets type as the CF type),
* fixes a wrong assumption in tests that UPSERT applies a change to Type (it creates a distinct record instead),
* Updates ACM model to use serial_number instead of deprecated and remove serial causing Travis failures.
2019-03-01 16:44:50 +00:00
Mike Grima
09855801ba
Merge pull request #2019 from acsbendi/launch_index
Correctly returning ami launch index
2019-02-25 12:16:40 -08:00
Mike Grima
3920f0e16b
Merge pull request #2060 from gregsterin/better-support-for-ddb-expressions
support a bit more of the dynamoDB ConditionExpression syntax
2019-02-25 10:03:02 -08:00
Berislav Kovacki
7e863b0260 Add attributes parameter support for sns create_topic API 2019-02-21 22:08:46 +01:00
William Rubel
e9d8021c86 Fixing list entities for policy 2019-02-18 21:20:29 -06:00
William Rubel
37845e41a6 Trying to improve coverage 2019-02-18 09:44:48 -06:00
William Rubel
c46bc9ae83 Trying to improve coverage 2019-02-18 09:15:07 -06:00
William Rubel
e229d248ad Trying to improve coverage 2019-02-18 08:52:37 -06:00
William Rubel
8048e39dc0 Fix policy date 2019-02-17 22:32:39 -06:00
William Rubel
ce7b5ebf54 Fix policy date 2019-02-17 21:37:33 -06:00
William Rubel
37a765db8d Fix policy date 2019-02-17 17:12:27 -06:00
William Rubel
0e73cddf2f Add test for roles 2019-02-17 16:25:49 -06:00
William Rubel
6e7bd088b3 Add test for roles 2019-02-17 16:04:28 -06:00
William Rubel
31258e9e9e Add test for roles 2019-02-17 15:23:59 -06:00
William Rubel
37cb5ab4e6 Add test for roles 2019-02-17 14:36:53 -06:00
William Rubel
921a993330 cleaning up files 2019-02-17 14:30:43 -06:00
William Rubel
e35d99ff09 Trying to improve coverage 2019-02-17 09:25:35 -06:00
William Rubel
8ad28f8400 Adding additional tests to increase coverage 2019-02-16 20:53:27 -06:00
William Rubel
5372e6840f Increasing code coverage 2019-02-16 12:37:46 -06:00
Domenico Testa
6897a118ed Fixing S3 copy_key error when using unicode. 2019-02-16 16:42:00 +01:00