Zach Brookler
31ce74a842
Fix autoscaling tags ( #3010 )
...
* ENH: Add unit test for propagation tags
* BUG: Add missing translation of boolean PropagateAtLaunch tag values to strings
* BUG: Should really be checking for "true" and not True
* CLN: Black formatting
2020-05-24 12:21:29 +01:00
Bert Blommers
1ef3094e45
SQS - Return multiple group-messages in the same request
2020-05-24 12:12:35 +01:00
Ben
8daafaec58
Add tag get_resource support for target groups ( #3012 )
2020-05-24 10:25:38 +01:00
Steve Pulec
59c71760ff
Keep order in request body to ensure auth signing works. ( #3024 )
...
* Keep order in request body to ensure auth signing works.
* Lint.
* More OrderedDict to ensure data parameter order.
* Lint.
* Improve CF test assertions.
* Fix syntax error.
* Cleanup CF test.
2020-05-24 08:51:45 +01:00
Zach Brookler
80b64f9b3f
Cloud formation "depends_on" #2845 Add depends on and update name type mapping ( #2994 )
...
* ENH: Add unit test for cloudformation DependsOn
* ENH: Add implementation of retrieving list of resources that account for dependencies
* ENH: Update the name mappings so that they are consistent with the latest cloudformation names
* ENH: Add launch configuration to type names
* ENH: Create subnet for test and test creation with dependencies
* CLN: Code reformatting
* CLN: Remove print statements
* BUG: Fix error resulting in possible infinite loop
* CLN: Remove commented out fixture decorator
* BUG: Remove subnet creation
* CLN: Remove main and ec2 dependencies
* BUG: Add back in instance profile name type
* CLN: Remove print
* BUG: Fix broken unit test
* CLN: Code reformatting
* CLN: Remove main
* ENH: Add autoscaling group name to type names
* ENH: Add unit test for string only dependency and add assertions to unit tests
* ENH: Add unit test for chained depends_on in cloudformation stack
* BUG: Remove f strings for python 2.7 compatibility
* BUG: List needs to be sorted for python2.7
* CLN: Fix code formatting
2020-05-18 09:47:18 +01:00
Steve Pulec
134cceeb12
Merge pull request #2996 from bblommers/athena_start_stop_execution
...
Athena - Start/Stop query execution, get_work_group
2020-05-16 15:37:42 -05:00
Bert Blommers
ffb521f86b
Linting
2020-05-16 15:03:26 +01:00
Bert Blommers
dd20fec9f3
Athena - Start/stop executions
2020-05-16 15:00:06 +01:00
Steve Pulec
0c9d97321e
Merge pull request #2995 from OneMainF/managedblockchain-addnode
...
Added node actions and other fixes
2020-05-16 08:17:52 -05:00
James Belleau
93311dbd4b
Added node actions and other fixes
2020-05-15 19:38:19 -05:00
Steve Pulec
17eb11a8d1
Merge pull request #2989 from bblommers/improve_coverage
...
Improve Implementation coverage
2020-05-14 17:55:55 -05:00
Steve Pulec
9712acc75f
Merge pull request #2986 from bblommers/dynamodb_transact_errors
...
#2985 - DynamoDB - TransactWriteItems - Fix error-type returned
2020-05-14 17:54:42 -05:00
Steve Pulec
464fea84f9
Merge pull request #2973 from bblommers/master
...
Lambda - Return LogResult only if requested
2020-05-14 17:53:49 -05:00
Steve Pulec
0f56539ef9
Merge pull request #2972 from bblommers/ses_validate_raw_email
...
SES - Validate domain before sending raw email
2020-05-14 17:52:50 -05:00
usmangani1
8d3d43da90
Enhancement Adding SES Functionalities CreateTemplate,GetTemplate,Lis… ( #2987 )
...
* Enhancement Adding SES Functionalities CreateTemplate,GetTemplate,ListTemplates
* Linting
Co-authored-by: usmankb <usman@krazybee.com>
Co-authored-by: Bert Blommers <info@bertblommers.nl>
2020-05-13 12:29:34 +01:00
James Belleau
9bc393801f
Managedblockchain member additions ( #2983 )
...
* Added some member and proposal functions
* Added additional member and proposal functions
* Fixed admin password return and added update_member along with tests
* Added network removal and member removal proposal
* Fixed failing test
* Fixed Python 2.7 test
2020-05-13 12:28:22 +01:00
Bert Blommers
d680b1e025
Merge remote-tracking branch 'spulec/master' into improve_coverage
2020-05-12 15:02:24 +01:00
usmangani1
774a764b69
Fix s3 Added Error handling in case of invalid uploadID ( #2979 )
...
* Added Error handling in case of invalid uploadID
* Linting
* added assertions
* Linting
Co-authored-by: usmankb <usman@krazybee.com>
Co-authored-by: Bert Blommers <info@bertblommers.nl>
2020-05-12 14:59:07 +01:00
Bert Blommers
ddb5c30d34
Improve implementation coverage (and layout)
2020-05-12 14:58:35 +01:00
Anton Grübel
e73a694219
Add CloudWatch logs subscription filters ( #2982 )
...
* Add logs.describe_subscription_filters
* Add logs.put_subscription_filter
* Add logs.delete_subscription_filter
* Change to usage of ACCOUNT_ID
2020-05-12 13:34:10 +01:00
Bert Blommers
48aa8ec3f9
#2985 - DynamoDB - TransactWriteItems - Fix error-type returned
2020-05-11 15:33:24 +01:00
Maxim Kirilov
1e0a7380d5
Add support for BlockDeviceMappings argument ( #2949 )
...
* Add support for BlockDeviceMappings argument upon run_instances execution
* Remove redundant check for Ebs existence
2020-05-11 13:23:45 +01:00
Denver Janke
9618e29ba9
Always call update ELBs for ASGs ( #2980 )
2020-05-11 07:44:26 +01:00
Anton Grübel
65e790c4eb
Add dynamodb continuous backups ( #2976 )
...
* remove print statement
* Add dynamodb.describe_continuous_backups
* Add dynamodb.update_continuous_backups
* Fix Python 2 timestamp error
2020-05-08 15:57:48 +01:00
pvbouwel
9e7803dc36
[Bugfix] UpdateExpression using ADD from zero ( #2975 )
...
When using the ADD syntax to sum up different components
the path that is provided is allowed to be non-existent.
In such a case DynamoDB will initialize it depending on
the type of the value.
If it is a number it will be initialized with 0.
If it is a set it will be initialized with an empty set.
2020-05-07 21:29:20 +01:00
Bert Blommers
0718525a2a
Linting
2020-05-07 12:29:18 +01:00
Bert Blommers
f1f7ddb69d
Merge pull request #2970 from rigaspapas/opsworks-online-status
...
Fix the online status in OpsWorks
2020-05-07 12:27:53 +01:00
Bert Blommers
e4caea586d
Merge pull request #2957 from OneMainF/add-managedblockchain
...
Add managedblockchain network functions #2956
2020-05-07 11:47:18 +01:00
Bert Blommers
ed109dae91
Merge pull request #2966 from usmangani1/SES_mod
...
SES get send statistics response modification
2020-05-07 11:30:32 +01:00
Bert Blommers
f82e834225
Lambda - Only return Logs if LogType=Tail
2020-05-07 10:55:15 +01:00
Bert Blommers
be5b1c592f
Lambda - Add actual logs to LogResult, instead of replicating the response
2020-05-07 10:40:24 +01:00
Bert Blommers
dcb122076f
Linting
2020-05-07 09:53:07 +01:00
Bert Blommers
691e206854
SES - Validate domain before send_raw_email
2020-05-07 09:49:37 +01:00
Rigas Papathanasopoulos
4abd88f95c
Fix the online status in OpsWorks
...
When an instance is running, OpsWorks reports its status as "online"
[1], while EC2 reports it as "running". Until now, moto copied the EC2
instance's status as is. This commit introduces the converts the running
status to online when returned by OpsWorks.
[1]: https://docs.aws.amazon.com/cli/latest/reference/opsworks/describe-instances.html
2020-05-07 10:57:27 +03:00
James Belleau
811ec3bd2a
Added get network test
2020-05-06 21:54:59 -05:00
James Belleau
5ec814a604
Fixes and additional tests
2020-05-06 21:12:48 -05:00
Brian Pandola
55f207050e
Add Redshift.ClusterAlreadyExists
Error
...
Closes #2967
2020-05-06 14:28:40 -07:00
Bert Blommers
2052a07ff7
Merge pull request #2962 from Chagui-/master
...
Implement parentGroup, namePrefixFilter and recursive for list_thing_groups()
2020-05-06 17:00:05 +01:00
usmankb
2b0e7da998
SES get send statistics response modification
2020-05-06 20:28:50 +05:30
Chagui-
8bfc7ed760
Fixed python2
2020-05-06 10:28:13 -04:00
Chagui-
c51ef87f71
black
2020-05-06 09:43:34 -04:00
Chagui-
f7b0484428
Refactored test_describe_thing_group_metadata_hierarchy to use generate_thing_group_tree
2020-05-06 09:37:43 -04:00
Chagui-
0869c83ea5
Refactored test_delete_thing_group to use generate_thing_group_tree
2020-05-06 09:32:47 -04:00
Chagui-
5fd8179653
Refactored test_list_thing_groups into class TestListThingGroup
2020-05-06 09:29:16 -04:00
Chagui-
40d1c8c9b9
Added generate_thing_group_tree function
2020-05-06 09:10:42 -04:00
gruebel
3b8c8fafe2
Fix ssm.get_parameters missing validation
2020-05-06 14:38:25 +02:00
Chagui-
e114eb9383
Added test test_list_thing_groups()
2020-05-05 18:08:56 -04:00
Bert Blommers
323877c15d
Merge pull request #2954 from usmangani1/LSTACK_AWSPROXY
...
Fix response_parameter being ignored in put_integration_response
2020-05-04 11:04:54 +01:00
Bert Blommers
2c9409faaa
Merge pull request #2946 from usmangani1/LSTACKISSUE909
...
SES Enhancement Adding get_send_statistics,create_configuration_set functions.
2020-05-04 10:07:03 +01:00
Bert Blommers
d6875c25cc
Linting
2020-05-04 09:27:57 +01:00
Bert Blommers
353bc08ac2
Linting
2020-05-04 09:24:46 +01:00
James Belleau
4365c2bd4e
Added network functions
2020-05-03 18:13:40 -05:00
usmankb
1cda64e9a3
Added tests
2020-05-03 08:31:46 +05:30
Kevin Neal
52cbdd72e7
update SQS MaximumMessageSize from 64K to 256K
2020-05-02 16:40:52 -07:00
Rifqi Al Fatih
f23f706825
Implement placement constraints model
2020-05-02 18:47:59 +02:00
Steve Pulec
8a1b24b234
Merge pull request #2947 from usmangani1/LSTACKISSUE1658
...
Fix SQS send_message_batch empty array Exception handling
2020-05-01 15:50:08 -05:00
Steve Pulec
464a9db192
Merge pull request #2945 from bblommers/feature/dynamodb_atomic_counter3
...
DynamoDB - Implement atomic counter
2020-05-01 15:47:53 -05:00
usmankb
1431348161
Fix SQS send_message_batch empty array Exception handling
2020-05-02 01:33:58 +05:30
usmankb
440213f854
Enhancement Adding SES get_send_statistics,create_configuration_set functions
2020-05-01 21:16:33 +05:30
Bert Blommers
2e737a6102
DynamoDB - Add tests to verify Atomic Counter functionality
2020-05-01 14:19:20 +01:00
Bert Blommers
49b00942c3
S3 DeleteObjects - Allow multiple querystring formats
2020-05-01 13:50:11 +01:00
Chagui-
95c459a86d
Added exception for deleting a group which has childs.
...
Added better tests for delete_thing_group
2020-04-30 17:21:45 -04:00
zscholl
1f1404352e
use conditional TEST_SERVER_MODE for backend tests
2020-04-30 09:42:22 -05:00
zscholl
0423be259a
remove backend logic & py27 incompatible timezone
2020-04-30 09:10:42 -05:00
zscholl
51e7002cbb
add tests
2020-04-30 09:10:42 -05:00
Bert Blommers
2d0087d500
Linting
2020-04-29 16:29:25 +01:00
usmankb
f4888da334
added test asserts and review comments
2020-04-29 18:02:02 +05:30
usmankb
84100c4483
enhancement Create-VPC-endpoint
2020-04-29 00:28:19 +05:30
Steve Pulec
f33e810e15
Merge pull request #2921 from getglad/support_optin_regions
...
Support OptInStatus for EC2 describe_region calls
2020-04-27 19:42:04 -05:00
Matthew Gladney
ff1beea280
Merge https://github.com/spulec/moto into support_optin_regions
2020-04-27 18:27:40 -04:00
Alessandro Palumbo
05860fcdd1
Fixed apigateway usage plan api when dealing with non existing usage plans and non existing api keys
2020-04-27 22:58:51 +02:00
Mike Grima
dd22e7855a
Fixed a regression with CloudWatch
2020-04-27 12:56:17 -07:00
Bert Blommers
b5a894dd89
Merge pull request #2919 from antoinewdg-mt/fix-s3-delete-objects-with-versioning
...
Handle VersionId in S3:delete_objects
2020-04-27 15:38:06 +01:00
Steve Pulec
30a98de687
Merge pull request #2924 from pvbouwel/ddb_full_parsing_executor
...
Improve DDB expressions support4: Execution using AST
2020-04-26 15:53:25 -05:00
Steve Pulec
60bcb46729
Merge pull request #2894 from microe/add_sts_assume_role_with_saml
...
Add the STS call assume_role_with_saml
2020-04-26 15:25:38 -05:00
Steve Pulec
2b255b0c5b
Merge pull request #2879 from bblommers/feature/dynamodb_transact_write_items
...
Feature: DynamoDB: transact_write_items
2020-04-26 15:20:19 -05:00
pvbouwel
ec731ac901
Improve DDB expressions support4: Execution using AST
...
Part of structured approach for UpdateExpressions:
1) Expression gets parsed into a tokenlist (tokenized)
2) Tokenlist get transformed to expression tree (AST)
3) The AST gets validated (full semantic correctness)
4) AST gets processed to perform the update -> this commit
This commit uses the AST to execute the UpdateExpression.
All the existing tests pass. The only tests that have been
updated are in test_dynamodb_table_with_range_key.py because
they wrongly allow adding a set to a path that doesn't exist.
This has been alligend to correspond to the behavior of AWS
DynamoDB.
This commit will resolve https://github.com/spulec/moto/issues/2806
Multiple tests have been implemented that verify this.
2020-04-26 15:59:12 +01:00
Bert Blommers
6a41573eb8
Merge pull request #2920 from lukaszpierog/handle-tags-and-description-in-secrets
...
Do not remove tags after secret update, handle description
2020-04-26 10:29:02 +01:00
Bert Blommers
56aa454397
Merge branch 'master' into feature/dynamodb_transact_write_items
2020-04-26 10:24:27 +01:00
Steve Pulec
efbb9c54a5
Merge pull request #2909 from oliparcol/bug/2759
...
S3 - Allow keys to start with leading slashes
2020-04-25 18:46:25 -05:00
Steve Pulec
fbc431dbff
Merge pull request #2837 from bblommers/bug/2810
...
EC2 - Explicitly set ebs_optimized to false if not specified
2020-04-25 18:44:48 -05:00
Steve Pulec
229b3ec196
Merge pull request #2838 from bblommers/feature/2388
...
CloudFormation - CreateChangeSet should not create resources
2020-04-25 18:44:18 -05:00
Steve Pulec
ac6c550fe6
Merge pull request #2852 from bblommers/feature/mock_eb
...
Add mock for ElasticBean
2020-04-25 18:42:25 -05:00
Steve Pulec
b24b7cb858
Merge branch 'master' into feature/extend_generic_tagger_to_s3
2020-04-25 18:40:50 -05:00
Steve Pulec
a35d1cb780
Merge pull request #2861 from bblommers/feature/883
...
Lambda - Add test to verify remove_permission functionality
2020-04-25 18:40:05 -05:00
Steve Pulec
365a2d140b
Merge pull request #2864 from bblommers/bugfix/2800
...
CognitoIdentity - Fix Format of Identity ID
2020-04-25 18:39:43 -05:00
Steve Pulec
b4a11cd19f
Merge pull request #2848 from bblommers/feature/2239
...
CloudWatch - Initial get-metric-data implementation
2020-04-25 18:39:21 -05:00
Steve Pulec
8595493aee
Merge branch 'master' into feature/dynamodb_item_limit
2020-04-25 18:38:08 -05:00
Steve Pulec
9c3f6c7592
Merge pull request #2825 from bblommers/feature/2699
...
EC2 - Add option to add volumes using CloudFormation
2020-04-25 18:36:26 -05:00
Steve Pulec
dbeb16d9b9
Merge pull request #2823 from bblommers/bug/2797
...
DynamoDB - Allow case insensitive AND in KeyConditionExpression
2020-04-25 18:35:51 -05:00
Steve Pulec
f4338876ff
Merge pull request #2834 from bblommers/feature/cloudwatch-integrated-metrics
...
Cloudwatch - Add default metrics for other services
2020-04-25 18:35:17 -05:00
JohnWC
4a800d8f2c
Updated for black
2020-04-25 11:24:54 -05:00
Olivier Parent Colombel
d852f7dd06
Fixing lint errors.
2020-04-25 17:49:50 +02:00
Olivier Parent Colombel
637e0188a2
Allow S3 keys to start with leading slashes.
2020-04-25 17:49:50 +02:00
JohnWC
0828c5af9d
Add unit test for add apigateway with policy
2020-04-25 03:27:59 -05:00
=
b63110be9e
handle description in describe secret operation, add tests
2020-04-24 21:47:11 +02:00
Matthew Gladney
59c1f0e131
black reformatting changes
2020-04-24 14:20:58 -04:00
Matthew Gladney
908468edb6
Support OptInStatus for EC2 describe_region calls
2020-04-24 14:15:22 -04:00
Antoine Wendlinger
9ed6e52d0a
Handle VersionId in S3:delete_objects
...
VersionId is not read in delete_objects requests, and the behavior
differs from its singular counterpart delete_object.
This fixes the issue.
2020-04-23 19:01:58 +02:00
Dmitry Ryzhikov
e866df9b9d
Merge branch 'master' into fix/table-filter-value-error
2020-04-22 20:08:05 +03:00
Bert Blommers
037c6e1320
Merge pull request #2914 from MarcosBernal/feature/add-get-databases-method-to-glue
...
Add get_databases method to glue and update IMPLEMENTATION_COVERAGE.md
2020-04-22 16:37:32 +01:00
Daniel Wallace
80b27a6b93
blacken
2020-04-21 21:43:32 -05:00
Daniel Wallace
49b056563a
process multipart form
2020-04-21 19:52:10 -05:00
Daniel Wallace
b3f6e5ab2f
add test
2020-04-21 18:07:50 -05:00
MarcosBernal
9381c670ab
change code style to pass black --check
2020-04-21 22:34:05 +02:00
MarcosBernal
753a39ed0d
Add get_databases method to glue moto client. Update IMPLEMENTATION_COVERAGE.md with methods that were covered previously
2020-04-21 20:10:39 +02:00
Bert Blommers
12ac1cbae2
Merge pull request #2911 from cm-iwata/fix_2910_list_thing_principal
...
Added existence check of target thing to IoT ListThingPrincipals
2020-04-21 07:47:12 +01:00
Tomoya Iwata
d9b782be0a
fix lint
2020-04-21 14:43:04 +09:00
Tomoya Iwata
b6789a2cc7
Added existence check of target thing to IoT ListThingPrincipals
...
fix #2910
2020-04-21 14:11:53 +09:00
Dmitry Ryzhikov
1a3a7d6a92
Add test for missing table name
2020-04-20 20:23:37 +03:00
pvbouwel
e6b51a28ee
Enable AST Validation
...
This commit puts AST validation on the execution path. This means updates get
validated prior to being executed. There were quite a few tests that were not
working against Amazon DDB. These tests I considered broken and as such this
commit adapts them such that they pass against Amazon DDB.
test_update_item_on_map()
=> One of the SET actions would try to set a nested element by specifying the nesting on the path
rather than by putting a map as a value for a non-existent key. This got changed.
test_item_size_is_under_400KB
=> Used the keyword "item" which DDB doesn't like. Change to cont in order to keep the same sizings.
=> Secondly the size error messages differs a bit depending whether it is part of the update or part
of a put_item. For an update it should be:
Item size to update has exceeded the maximum allowed size
otherwise it is
Item size has exceeded the maximum allowed size'
test_remove_top_level_attribute
=> Used a keyword item. Use ExpressionAttributeNames
test_update_item_double_nested_remove
=> Used keywords name & first. Migrated to non-deprecated API and use ExpressionAttributeNames
test_update_item_set &
test_boto3_update_item_conditions_pass &
test_boto3_update_item_conditions_pass_because_expect_not_exists &
test_boto3_update_item_conditions_pass_because_expect_not_exists_by_compare_to_null &
test_boto3_update_item_conditions_pass_because_expect_exists_by_compare_to_not_null &
test_boto3_update_item_conditions_fail &
test_boto3_update_item_conditions_fail_because_expect_not_exists &
test_boto3_update_item_conditions_fail_because_expect_not_exists_by_compare_to_null
=> Were broken tests which had string literal instead of value placeholder
2020-04-19 16:58:46 +01:00
pvbouwel
fc4d88401d
Improve DDB expressions support3: AST Validation
...
Part of structured approach for UpdateExpressions:
1) Expression gets parsed into a tokenlist (tokenized)
2) Tokenlist get transformed to expression tree (AST)
3) The AST gets validated (full semantic correctness) -> this commit
4) AST gets processed to perform the update
This commit uses the AST to perform validation. Validation makes sure the
nodes encounterd have valid values and they will also resolve values for
references that refer to item state or values passed into the expression.
2020-04-19 16:58:07 +01:00
pvbouwel
9ed613e197
Better DDB expressions support2: ExpressionTree
...
Part of structured approach for UpdateExpressions:
1) Expression gets parsed into a tokenlist (tokenized)
2) Tokenlist get transformed to expression tree (AST) -> This commit
3) The AST gets validated (full semantic correctness)
4) AST gets processed to perform the update
This commit uses the tokenlist to build an expression tree. This tree is not
yet used. Still it allows to raise additional Validation Exceptions which
previously were missed silently therefore it allows tests to catch these type of
ValidationException. For that reason DDB UpdateExpressions will be parsed
already. It also makes sure we won't break existing tests.
One of the existing tests had to be changed in order to still pass:
- test_dynamodb_table_with_range_key.test_update_item_with_expression
This test passed in a numeric literal which is not supported by DynamoDB
and with the current tokenization it would get the same error as in AWS
DynamoDB.
2020-04-18 09:19:03 +01:00
pvbouwel
7ea419dd54
Better DDB expressions support1: TokenizationDDB
...
Currently the mock for DynamoDB has adhoc code to implement
its updateExpression functionality. This series will
transform the logic such that Update Expressions are processed
as follows:
1) Expression gets parsed into a tokenlist (tokenized) -> This commit
2) Tokenlist get transformed to expression tree (AST)
3) The AST gets validated (full semantic correctness)
4) AST gets processed to perform the update
This alows for a more realistic mocking. It will throw exceptions much
more aggressively avoiding situations where a test passes against the
mock but fails with an exception when running against AWS.
Introduction of step 3 also allows to have the update expression as an
atomic unit of work. So updates at the start of the expression cannot
be performed if there is an error further down the expression.
This specific commit will tokenize expressions but the tokenlist is not
yet used. It is purely to keep clear boundaries. It does do a minor
refactoring of the exceptions to allow more re-use and to ease testing.
This series of changes is to aid providing a long-term solution for
https://github.com/spulec/moto/issues/2806 .
2020-04-18 09:16:23 +01:00
Mike Grima
bdeeeb701a
Merge pull request #2880 from bblommers/bugfix/2877
...
EC2 - Ensure NCI always has a Subnet
2020-04-16 15:02:45 -07:00
Hugo Lopes Tavares
4dc46a697d
Bugfix: Allow stop_db_instance for compatible engines
...
From the RDS documentation:
You can stop and start a DB instance whether it is configured for a single Availability Zone or for Multi-AZ, for database engines that support Multi-AZ deployments. You can't stop an Amazon RDS for SQL Server DB instance in a Multi-AZ configuration.
https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_StopInstance.html#USER_StopInstance.Limitations
2020-04-16 15:14:37 -04:00
Erik Hovland
88494c58f9
Add a test for assume_role_with_saml.
...
Add a test with SAML assertion to test the assume_role_with_saml method
in the STSBackend.
2020-04-16 11:47:30 -07:00
Tim
92bbc3fbac
Adds initial support for secretsmanager update_secret
...
The support in this patch is preliminary and may or may not be feature complete.
It provides the basic support for update_secret so that future work can build
on it as needed.
2020-04-16 08:20:43 -07:00
Bert Blommers
870b34ba76
Spacing
2020-04-16 07:09:50 +01:00
Bert Blommers
47d80621f9
Merge branch 'master' into feature/dynamodb_item_limit
2020-04-16 07:07:59 +01:00
Bert Blommers
a6902e8713
Update tests/test_dynamodb2/test_dynamodb.py
...
Co-Authored-By: Guilherme Martins Crocetti <gmcrocetti@gmail.com>
2020-04-15 07:26:09 +01:00
Bert Blommers
532480a3b5
Merge pull request #2888 from usmangani1/lstack#1991
...
Added implementation for create-model,get-models,get-model in api gat…
2020-04-14 10:34:39 +01:00
Bert Blommers
69f963a3c2
Linting
2020-04-14 08:06:00 +01:00
Bert Blommers
d0c60ecaac
Merge pull request #2891 from DenverJ/enhancement/autoscaling-standby-terminate
...
Implement enter_standby, exit_standby and terminate_instance_in_auto_scaling_group
2020-04-14 08:01:50 +01:00
Bert Blommers
c2b4c397f2
DDB test - Fix KeySchema, and set BillingMode for easier online testing
2020-04-14 07:53:15 +01:00
Bert Blommers
b63a6f1336
Merge pull request #2884 from usmangani1/2263_Issue
...
Adding missing Param zoneId in the ec2 describe-availability-zone
2020-04-14 07:12:51 +01:00
DenverJ
d745dfd3d2
Implement enter_standby, exit_standby and terminate_instance_in_auto_scaling_group
2020-04-13 10:54:13 +10:00
usmankb
79e63e3bcf
Added implementation for create-model,get-models,get-model in api gateway
2020-04-12 17:49:22 +05:30
Bert Blommers
755a08e137
Merge pull request #2887 from DenverJ/enhancement/fix-describe-autoscaling-instances-filter
...
Add instance-id filter to describe_auto_scaling_instances
2020-04-12 11:09:31 +01:00
DenverJ
965046aa39
Fix formatting
2020-04-12 17:08:40 +10:00
DenverJ
593e5dc86a
Add instance-id filter to describe_auto_scaling_instances
2020-04-12 13:44:16 +10:00
usmankb
7a9cdd4fd2
Adding missing Param zoneId in the describe-availability-zone
2020-04-11 08:37:00 +05:30
Bert Blommers
48288d8bb1
Merge pull request #2878 from usmangani1/2187_Issue
...
Adding functionalities aws apigateway create domain name,get domain names,get domain name
2020-04-09 08:58:05 +01:00
Bert Blommers
1654280e43
Linting
2020-04-09 08:12:44 +01:00
usmankb
8542309fc9
conflicts
2020-04-08 22:00:48 +05:30
usmankb
af57cfc7ec
Added more tests and coverage
2020-04-08 21:54:26 +05:30
Bert Blommers
414fcf7bbd
Fix AvailibilityZones in CF tests
2020-04-08 15:14:39 +01:00
Bert Blommers
8475804a8b
Simplify tests
2020-04-08 14:02:35 +01:00
Bert Blommers
5c7e0b56af
#2877 - Ensure NetworkInterfaces are assigned to the default Subnet
2020-04-08 13:53:53 +01:00
Bert Blommers
8237fdaff0
Linting
2020-04-08 11:06:30 +01:00
Bert Blommers
54f51fc7c1
DynamoDB - TransactWriteItems implementation
2020-04-08 10:49:58 +01:00
Bert Blommers
3b9717d5b1
Merge pull request #2876 from tmwong2003/tmwong2003/ecs-run-task-support-default-cluster
...
Changed mock_ecs to support ecs.run_task calls with a default cluster
2020-04-08 07:53:27 +01:00
Theodore Wong
0163eb6a9d
Changed mock_ecs to support ecs.run_task calls with a default cluster
2020-04-07 15:32:44 -07:00
usmankb
856c07de63
aws apigateway create,get domain names
2020-04-08 03:18:42 +05:30
Bert Blommers
aae49493c4
Linting
2020-04-07 08:52:37 +01:00
usmankb
81ca5c3ab0
Implemented describe_instance_credit_specifications function in ec2 #2150 localstack
2020-04-06 21:25:59 +05:30
jess
49fd7988ab
make black happy
2020-04-06 19:55:54 +10:00
jess
4c2460ddfd
fix whitespace changes
2020-04-06 18:45:23 +10:00
jess
b6e73776d5
alter testcase to trigger issue #2868
2020-04-06 18:41:46 +10:00
Bert Blommers
280db9df6c
#2800 - CognitoIdentity - Fix format of Identity ID
2020-04-04 14:09:38 +01:00
mickeypash
a6864f483d
Use Python 2 format
2020-04-03 14:17:55 +01:00
Bert Blommers
9ab02e17d5
#883 - Lambda - Add test to verify remove_permission functinonality
2020-04-03 10:30:05 +01:00
mickeypash
d3367b8a90
Black formatting
2020-04-03 02:27:46 +01:00
mickeypash
76b9cbe16d
Fix test
2020-04-03 02:14:14 +01:00
mickeypash
231b100057
Add test scaffold. Currently broken
2020-04-03 01:58:14 +01:00
Guilherme Martins Crocetti
503eeb51ae
style with black
2020-04-01 22:48:40 -03:00
Guilherme Martins Crocetti
c25f6a72da
refactor put_rule test
2020-04-01 22:14:51 -03:00
Guilherme Martins Crocetti
c15ca133b8
add support for Fn::GetAtt in event's cloudformation
2020-04-01 22:14:51 -03:00
Guilherme Martins Crocetti
af08d71310
add support for RetentionInDays for LogGroup
2020-04-01 22:14:41 -03:00
Bert Blommers
8dbfd43c5c
Use TaggingService for S3 - Cleanup
2020-04-01 15:35:25 +01:00
Bert Blommers
f7ad4cbc09
Use TaggingService for S3 Objects
2020-03-31 12:04:04 +01:00
Mike Grima
0c191ac33b
Raise errors on tagging buckets with aws:*
...
Cannot tag S3 buckets with reserved tag key space `aws:`
2020-03-30 17:27:06 -07:00
Bert Blommers
7d524eaec9
Elastic Beanstalk - Rename and Add Implementation Coverage
2020-03-30 14:08:22 +01:00
Bert Blommers
888e0c31a0
Linting
2020-03-30 13:42:00 +01:00
Bert Blommers
3ece2dabff
Merge remote-tracking branch 'nielslaukens/feature/mock_eb' into feature/mock_eb
2020-03-30 13:38:56 +01:00
Andrea Amorosi
349b381390
Fixed dynamodb2 put_item ValidationException
2020-03-28 17:59:42 +00:00
Bert Blommers
fb0de99e81
#2239 - Initial implementation of CW.get_metric_data
2020-03-28 13:41:17 +00:00
Constantino Schillebeeckx
bb8d418054
fix: stepfunction stop_execution
...
Fixes #2846
Calling stop_execution on a stepfunction should set the status to `ABORTED` not `SUCCEEDED`.
2020-03-27 15:35:50 -05:00
Bert Blommers
04f488da62
#2388 - CloudFormation - CreateChangeSet does not create resources, as per spec
2020-03-24 10:22:08 +00:00
Bert Blommers
11526ced18
#2810 - EC2 - Explicitly set ebs_optimized to False if not specified
2020-03-24 09:24:38 +00:00
Guilherme Martins Crocetti
788b8fb6e1
Add tests for Events::Rule integration with cf
2020-03-23 22:17:02 -03:00
Bert Blommers
c3865532f9
#2711 - Register default S3 metrics in CloudWatch
2020-03-23 15:53:39 +00:00
Guilherme Martins Crocetti
98a17dfc46
Add test for boto3 integration
2020-03-22 18:03:42 -03:00
Guilherme Martins Crocetti
a1f664d2bb
Change put_rule (and it's response) and fix tests_events/
2020-03-22 17:33:44 -03:00
Guilherme Martins Crocetti
7318523b50
Add cloudformation support for EventBridge
2020-03-22 16:56:58 -03:00
gruebel
23dfecc845
Fix missing MessageAttributes when using RawMessageDelivery
2020-03-21 19:25:25 +01:00
Bert Blommers
e82e1e3f39
DynamoDB - Add 1MB item size check
2020-03-21 12:20:09 +00:00
Bert Blommers
5b596c8a78
#2699 - EC2 - Add Volumes using CloudFormation
2020-03-20 15:17:55 +00:00
Bert Blommers
b1da99aeda
#2797 - DynamoDB - Allow case insensitive AND in KeyConditionExpression
2020-03-20 12:29:04 +00:00
Steve Pulec
94f85902bc
Merge pull request #2821 from bblommers/feature/2255
...
CloudFormation - Add Support for FN:Transform and AWS:Include
2020-03-19 19:40:46 -05:00
Steve Pulec
0903f6a4a2
Merge pull request #2820 from bblommers/bug/2264
...
SES - Parse email address on verification
2020-03-19 19:39:45 -05:00
Steve Pulec
14b2811157
Merge pull request #2819 from bblommers/dynamodb_global_index_ordering
...
Dynamodb - Global index ordering
2020-03-19 19:39:09 -05:00
Steve Pulec
b0ea0aa162
Merge pull request #2818 from bblommers/cloudformation_stack_creation_time
...
Cloudformation - Stack creation time
2020-03-19 19:38:46 -05:00
Steve Pulec
78f5541953
Merge pull request #2817 from bblommers/dynamodb_add_index_status
...
DynamoDB - Add status to Global Indexes
2020-03-19 19:37:49 -05:00
Bert Blommers
cbf0397953
#2255 - CF - Implement FN::Transform and AWS::Include
2020-03-18 13:02:07 +00:00
Bert Blommers
f0cab68208
#2264 - SES - Ensure verify_email_address works with display names
2020-03-18 11:46:44 +00:00
Bert Blommers
71bf314a0f
Merge pull request #2799 from ImFlog/fix_dynamodb_updated_new
...
Fix UPDATED_NEW return values differences
2020-03-18 08:21:01 +00:00
Bert Blommers
aead80c392
Add missing region
2020-03-17 17:11:35 +00:00
Bert Blommers
67c7fce85e
#2760 - DynamoDB - Ensure proper ordering for Numeric sort keys
2020-03-17 16:28:49 +00:00
Bert Blommers
3fab3f572f
#2773 - CloudFormation - Set CreationDate
2020-03-17 16:09:42 +00:00
Bert Blommers
b7da6b9481
#2813 - DynamoDB - Add Global Index Status
2020-03-17 15:41:50 +00:00
Tim Gatzemeier
6e490a9190
make linter happy
2020-03-16 21:58:50 +01:00
Tim Gatzemeier
50974aa9b2
add test cases to ensure actions enabled is correctly returned
2020-03-16 21:45:29 +01:00
Tim Gatzemeier
9d3ee116d3
add test case for actions_enabled field
2020-03-16 20:14:41 +01:00
Steve Pulec
6a887e52cc
Merge pull request #2808 from bblommers/feature/2201
...
Batch - various fixes
2020-03-15 16:45:57 -05:00
Steve Pulec
77b1cc2321
Merge pull request #2809 from bblommers/feature/dynamodb-transact-get-items
...
Feature - DynamoDB: transact_get_items
2020-03-15 16:45:03 -05:00
Steve Pulec
e81063aa99
Merge pull request #2802 from bblommers/bugfix/cloudformation-iam-role-name
...
Cloudformation - Set IAM role name
2020-03-15 16:43:31 -05:00
Steve Pulec
091b6cdef4
Merge pull request #2801 from bblommers/bugfix/cloudwatch_timestamp
...
Cloudwatch - Fix timestamp format
2020-03-15 16:43:03 -05:00
Steve Pulec
6b97a4ab96
Merge pull request #2796 from bblommers/feature/1054
...
DynamoDB - Improve error handling for put_item without keys
2020-03-15 16:41:59 -05:00
Steve Pulec
4cf24701c5
Merge pull request #2795 from bblommers/feature/657
...
S3 - Verify content type is set/returned as appropriate
2020-03-15 16:41:14 -05:00
Steve Pulec
dfe0047077
Merge pull request #2792 from bblommers/bugfix/718
...
EC2 - Allow filtering by multiple tags
2020-03-15 16:40:33 -05:00
ImFlog
7f6c6660aa
Add some new update_new tests
2020-03-13 09:37:50 +01:00
Bert Blommers
71d3941daf
Linting
2020-03-12 14:26:23 +00:00
Bert Blommers
caebe222d7
DynamoDB - Transact_get_items - Remove error condition
2020-03-12 14:24:53 +00:00
Tomoya Iwata
b74625db0c
add support for dynamodb transact_get_items
2020-03-12 14:15:13 +00:00
Bert Blommers
1b031aeeb0
Linting
2020-03-12 14:07:34 +00:00
Bert Blommers
bb5a54ca4b
Batch - Fix tests
2020-03-12 13:37:46 +00:00
mzgierski
ad5314ad06
Enable the test that AWS-Batch describe_jobs fails at.
2020-03-12 12:27:22 +00:00
Brent Driskill
e3e4b741d8
SSM: Fix the formatting associated with label_parameter_version/get_parameter_history updates
2020-03-11 11:57:04 -04:00
Brent Driskill
5705695495
SSM: Added support for label_parameter_version and getting labels on get_parameter_history
2020-03-11 10:43:18 -04:00
Bert Blommers
9163f04292
Linting
2020-03-11 13:19:40 +00:00
Luis Pollo
20364b177a
Fix IAM role name when parsed from CloudFormation JSON.
2020-03-11 13:17:35 +00:00
Bert Blommers
0e43369155
Linting
2020-03-11 12:47:40 +00:00
Huang syunwei
ab68d14649
Fix bug of put metric data with timestamp, timestamp should be a date time object instead of a string
2020-03-11 12:47:09 +00:00
ImFlog
ba1bf09474
Fix UPDATED_NEW return values differences between moto and dynamoDB
2020-03-10 18:22:54 +01:00
Bert Blommers
315ac32f09
Add region to test case
2020-03-10 14:28:12 +00:00
Bert Blommers
e9930b0cb2
S3 - test fix - Use plain text as content, instead of file
2020-03-10 13:30:38 +00:00
Bert Blommers
6ba00d9ad1
#1054 - DynamoDB - Improve error handling for put_item without keys
2020-03-10 13:25:40 +00:00
Bert Blommers
f17d5f8e4d
#657 - S3 - Verify content type is set/returned as appropriate
2020-03-10 12:56:33 +00:00
Bert Blommers
9eeb375911
Add region to test case
2020-03-10 09:26:44 +00:00
Bert Blommers
dc98fca853
#718 - Allow filtering by multiple tags
2020-03-09 15:14:51 +00:00
Bert Blommers
7b5613b331
#2774 - Re-add test, and update requirements to working botocore
2020-03-09 12:47:44 +00:00
Dick Marinus
28af7412f8
Change RESTError to JsonRESTError for ImageNotFoundException, update test to expect ImageNotFoundException
2020-03-08 20:56:21 +01:00
Steve Pulec
a92f862e86
Merge pull request #2764 from bblommers/feature/ec2-describe-instance-filters
...
Feature - EC2 describe_instance_status now uses filters
2020-03-07 11:47:05 -06:00
Steve Pulec
05236684f4
Merge pull request #2763 from bblommers/bugfix/multiple_items_in_ddbstream
...
DynamoDB Streams: Bugfix when sending multiple items
2020-03-07 11:46:24 -06:00
Steve Pulec
4cb23837e0
Merge pull request #2647 from aimannajjar/2646_create_default_ipv6_egress_rule
...
Security Groups - Create a second default egress rule for IPv6
2020-03-07 11:33:57 -06:00
Steve Pulec
51da32825d
Merge pull request #2785 from addomafi/master
...
Enhancement: Adding support to EbsConfiguration on configuration of Instance Groups for an EMR Endpoint
2020-03-07 11:03:27 -06:00
Steve Pulec
3dca5a3fe8
Merge pull request #2772 from bblommers/bugfix/#2567
...
Bugfix - When mocking URLs, always return the first match
2020-03-07 10:33:34 -06:00
Steve Pulec
f01108f687
Merge pull request #2767 from jrbeilke/feature-config-putevaluations
...
Feature: Add test mode support for Config PutEvaluations
2020-03-07 10:16:34 -06:00
addomafi
c6eca18434
Reformat
2020-03-06 18:11:07 -03:00
addomafi
23771549c2
#2784 Implementing assertions for testcase with instance groups
2020-03-06 18:10:39 -03:00
addomafi
c8dfbe9575
#2784 Adding missing support for EbsConfiguration on EMR instance groups
2020-03-06 15:12:44 -03:00
Bert Blommers
fbb449aa48
Merge branch 'master' into bugfix/#2567
2020-03-06 12:18:06 +00:00
addomafi
f7acdb9b3a
Merge branch 'master' of github.com:spulec/moto
2020-03-06 08:40:05 -03:00
Bert Blommers
a86f459ac9
Merge pull request #2770 from oanise93/fix_ssm_delete_parameter
...
Changes behavior of delete_parameter when parameter doesn't exist
2020-03-06 08:39:49 +00:00
Bert Blommers
e895c6d6cd
Merge pull request #2779 from jonnangle/feature-failover-geo
...
Support GeoLocation and Failover on Route 53
2020-03-06 08:39:08 +00:00
Bert Blommers
03164e7b60
Merge pull request #2780 from heyderpd/master
...
fixing error when _get_default return value that already exists, on _get_appended_list
2020-03-06 08:38:49 +00:00
Bert Blommers
15444bd4f7
Merge pull request #2783 from EpicWink/swf-undeprecate
...
Add SWF domain and type undeprecation
2020-03-06 08:37:36 +00:00
heyder.dias
f5080e539d
fix lint check
2020-03-05 18:39:20 -03:00
addomafi
a9b0677667
#2784 Adding missing support for EbsConfiguration on EMR run_job_flow
2020-03-05 18:11:49 -03:00
heyder.dias
fa7f83bc2f
add test to nested if_not_exists and property already exists
2020-03-05 17:05:00 -03:00
Steve Pulec
9024031ca2
Merge pull request #2776 from bblommers/python-2-readyness
...
Python 2 dependencies + Test fix
2020-03-05 12:58:27 -06:00
Bert Blommers
c6b66cb001
Linting
2020-03-05 17:22:54 +00:00
Bert Blommers
b19cf8a085
#2774 - Run Policy test on different method
2020-03-05 15:49:30 +00:00
Laurie O
916add9ac5
Add SWF domain and type undeprecation
...
Signed-off-by: Laurie O <laurie_opperman@hotmail.com>
2020-03-05 23:37:17 +10:00
Jon Nangle
bebcf52851
Formatting
2020-03-02 13:07:34 +00:00
Jon Nangle
9fdeaca589
Support GeoLocation and Failover on Route 53
2020-03-02 12:46:15 +00:00
aimannajjar
639c1abcb4
clarifying comment in test case
2020-03-01 08:23:31 -05:00
aimannajjar
5b9b965647
[ec2-sg] added logic to create a second default egress rule for ipv6
2020-02-29 21:05:05 -05:00
Olabode Anise
9227845121
using assert_raises
2020-02-27 07:29:13 -05:00
Bert Blommers
47349b30df
#2567 - When mocking URLs, always return the first match
2020-02-27 08:54:57 +00:00
Olabode Anise
607e0a8452
ENH: changes the behavior of delete_parameter to respond with a 400 error when the parameter does not exist.
...
Currently, the delete_parameter function for the ssm client will respond with a dict containing a key of Invalid Parameter which has a value of a list containing the parameter name that was requested to be deleted when a parameter with said name doesn't exist which doesn't match the behavior of boto3.
2020-02-26 07:13:32 -05:00
Bert Blommers
f8af496445
Merge pull request #2769 from EpicWink/swf-empty-task
...
Return empty task-token on no-task
2020-02-25 17:05:16 +00:00
Laurie O
209c999706
Keep track of previous started event ID
...
Closes #2107
Signed-off-by: Laurie O <laurie_opperman@hotmail.com>
2020-02-26 01:08:03 +10:00
Laurie O
369285b7ca
Don't 0-default previous started event ID
...
Signed-off-by: Laurie O <laurie_opperman@hotmail.com>
2020-02-26 01:06:58 +10:00
Laurie O
002683fd13
Return empty task-token on no-task
...
To match the SWF documentation, an empty task is one where the
task-token is the empty string, rather than being a nonexistant key
Signed-off-by: Laurie O <laurie_opperman@hotmail.com>
2020-02-26 00:19:39 +10:00
Jon Beilke
c3581dbd0b
add missing os import for config tests
2020-02-24 13:25:36 -06:00
Jon Beilke
4c43ca362f
add workaround for NotImplementedError failing server mode tests
2020-02-24 13:01:38 -06:00
Jon Beilke
28b4305759
add rudimentary support for Config PutEvaluations with TestMode for now
2020-02-24 11:53:27 -06:00
Bert Blommers
3aeb5f5043
Linting
2020-02-24 13:43:58 +00:00
Bert Blommers
939bd1cd86
EC2 - Add some filters for describe_instance_status
2020-02-24 13:43:19 +00:00
Bert Blommers
038ff620b2
DDB Streams - Bugfix where processed items are resend every time
2020-02-24 09:28:52 +00:00
Bert Blommers
736f8b5a8f
Refactor - reuse logic that expects CW log message
2020-02-24 08:24:14 +00:00
Steve Pulec
a89c150627
Merge pull request #2761 from bblommers/bugfix/1427
...
EMR - Return start time of first step
2020-02-22 18:26:01 -06:00
Bert Blommers
dc9129955b
Merge pull request #2758 from brady-gsa/kms-tagging
...
Kms tagging and untag support
2020-02-22 10:25:43 +00:00
Brady
c162f02091
re-add coverage and remove unused import
2020-02-21 15:39:23 -05:00
Brady
1221d2653a
fix test cases, bug when no tags are present and conflict
2020-02-21 15:21:41 -05:00
Bert Blommers
7205ab7785
#1427 - EMR - Return start time of first step
2020-02-20 08:59:21 +00:00
Bryan Alexander
38413577fc
fixes bug in resourcetaggingapi/get_kms_tags
2020-02-19 09:18:01 -06:00
Steve Pulec
ec3f6bbc6c
Merge pull request #2757 from jrbeilke/feature-apigw-authorizers
...
Feature: add support for API Gateway authorizers
2020-02-18 18:52:58 -06:00
Steve Pulec
3f8ea90475
Merge pull request #2756 from EpicWink/swf-workflow-defaults
...
Support default task-priority and Lambda-role in SWF workflow registration
2020-02-18 18:45:46 -06:00
Steve Pulec
d297fc08f2
Merge pull request #2755 from bblommers/dynamodbstreams_update_item
...
DynamoDB - Send item to DDB Stream on update, not just on create
2020-02-18 18:15:25 -06:00
Bryan Alexander
d1efedec29
updates kms to use tagging service and support untag_resource
2020-02-18 13:40:34 -06:00
Jon Beilke
40208363be
Merge branch 'master' into feature-apigw-authorizers
2020-02-18 10:49:53 -06:00
Jon Beilke
1d14085294
add API Gateway authorizers
2020-02-18 10:49:35 -06:00
Bryan Alexander
445f474534
merging from master
2020-02-18 10:47:05 -06:00
Bert Blommers
100dbd529f
Merge pull request #2742 from xnegativx/master
...
MessageAction for cognito admin_create_user is now handled
2020-02-18 13:41:02 +00:00
Bert Blommers
5863d9fab9
Linting
2020-02-18 12:34:24 +00:00
Laurie O
979d20753c
Support more defaults in SWF workflow registration
...
SWF workflow type now keeps track of the default task-priority and
default AWS Lambda role, set at workflow registration.
2020-02-18 21:59:06 +10:00
Bert Blommers
9971bcdfcd
DynamoDB - Send item to DDB Stream on update, not just on create
2020-02-18 11:49:55 +00:00
Steve Pulec
11e64109eb
Fix s3 test for location constraint.
2020-02-17 20:32:28 -06:00
Steve Pulec
dcd1f0195f
lint.
2020-02-17 20:32:19 -06:00
Steve Pulec
356c55f99d
Fix default resourceMethod for API Gateway. Closes #2750 .
2020-02-17 20:21:25 -06:00
Steve Pulec
6b6a059350
Merge pull request #2132 from Projectplace/tagging-directive
...
Support x-amz-tagging-directive in s3 copy_object
2020-02-17 20:00:30 -06:00
Steve Pulec
a1ffb47ae4
Merge pull request #2751 from mikegrima/s3control
...
Implemented S3 Account-level public access block.
2020-02-17 19:53:15 -06:00
Steve Pulec
4a89131ec4
Merge pull request #2694 from brady-gsa/events-tagging
...
adds tagging support for cloudwatch events service
2020-02-17 18:51:09 -06:00
Steve Pulec
88828576a6
Merge pull request #2753 from jrbeilke/bug-cognito-userpool-arn
...
Bug: Arn missing from cognito user pool model and response
2020-02-17 18:49:14 -06:00
Steve Pulec
b252ab6675
Merge pull request #2173 from sthuber90/master
...
Extending IoT Policy and Jobs functionality
2020-02-17 17:55:03 -06:00
Mike Grima
11b7be0e85
Implemented S3 Account-level public access block.
...
- Also added AWS Config listing and fetching support
- Also fixed Lambda test breakage
2020-02-17 15:41:27 -08:00
Steve Pulec
aeb194fc57
Update new lambda test to work with updated status codes. CC #2642 .
2020-02-17 17:29:00 -06:00
Jon Beilke
92fc39d7bb
add Arn to cognito user pool model and response
2020-02-17 15:08:09 -06:00
Bert Blommers
d463c11793
Merge pull request #2745 from EpicWink/closed-execution-info
...
Include closed execution extra info
2020-02-17 08:53:49 +00:00
Steve Pulec
9cf6123669
Merge pull request #2748 from jrbeilke/feature-apigw-apikeyrequired
...
Feature: API Gateway default value for apiKeyRequired on methods
2020-02-15 11:36:17 -06:00
Steve Pulec
039656f84d
Merge pull request #2704 from bblommers/bugfix/2642
...
Fix AWS Lambda status code on invoke
2020-02-15 10:46:01 -06:00
Steve Pulec
e40d75359a
Merge pull request #2717 from bblommers/feature/s3_illegallocationconstraint
...
S3 Feature: Add IllegalLocationConstraintException
2020-02-15 10:41:00 -06:00
Steve Pulec
a0999ced8a
Merge pull request #2740 from bblommers/bugfix/#2580
...
DynamoDB update_item: Allow list_append and if_not_exists-functions in one expression
2020-02-15 10:39:47 -06:00
Steve Pulec
200cd7c3e1
Merge pull request #2738 from bblommers/bugfix/2732
...
EC2 AMI Creation bugfix - Fix AMI owner
2020-02-15 10:37:03 -06:00
Jon Beilke
8a51fbe1c9
add default for apiKeyRequired field on API Gateway methods
2020-02-14 12:26:27 -06:00
Laurie O
353ad631f0
Include closed execution extra info
...
Include 'closeStatus' and 'closeTimestamp' when describing SWF workflow
execution using 'describe_workflow_execution'
Signed-off-by: Laurie O <laurie_opperman@hotmail.com>
2020-02-15 01:23:09 +10:00
Bert Blommers
1b4d0b7a1d
Merge pull request #2733 from griffint61/feature/lambda_get_function_ResourceNotFoundException
...
Added 'x-amzn-ErrorType' in the return header for missing lambda function
2020-02-12 07:44:21 +00:00
Terry Griffin
f70cd0182e
Fixed test_lambda_can_be_deleted_by_cloudformation for new (correct) error code.
2020-02-10 09:18:25 -08:00
Antonin
fa3904df29
MessageAction for cognito admin_create_user is now handled
...
If an invitation is attempted to be reset to a pool we validate that the user is indeed already in the pool else we raise a UserNotFoundException to match AWS behaviour
2020-02-10 18:09:15 +01:00
Bert Blommers
2bd93a76fc
Add region to DDB tests
2020-02-09 11:58:41 +00:00
Bert Blommers
936d686392
#2580 - DynamoDB update_item: Allow list_append and if_not_exists-functions in one expression
2020-02-09 11:47:02 +00:00
Bert Blommers
df031d0f33
#2732 - Created AMI should have AccountID as the OwnerID
2020-02-08 10:58:31 +00:00
Bert Blommers
39751a6961
Merge pull request #2737 from jmsanders/limit-list-queues-to-1000
...
Limit SQS list_queues response to 1000 queues
2020-02-08 09:23:22 +00:00
Nikita Antonenkov
d4caf14b61
Fixed UnboundLocalError in dynamodb2.query when no filters are passed
2020-02-07 23:39:31 +01:00
jmsanders
0b7e990bbf
Limit SQS list_queues response to 1000 queues
...
The maximum number of queues that the ListQueues API can return is 1000:
https://docs.aws.amazon.com/AWSSimpleQueueService/latest/APIReference/API_ListQueues.html
2020-02-07 15:54:42 -06:00
Bert Blommers
32dc8f9fe7
Merge pull request #2734 from gruebel/fix-kms-create-key
...
Fix kms create key
2020-02-07 16:23:17 +00:00
gruebel
ec56351416
Move boto3 tests to separate file
2020-02-07 16:28:23 +01:00
gruebel
4833419499
Fix CreationDate handling
2020-02-07 15:38:37 +01:00
Terry Griffin
b4c9b76ca9
Added 'x-amzn-ErrorType' in return header from lambda:get_function for missing function
2020-02-06 15:26:20 -08:00
gruebel
5d05044491
Add CustomerMasterKeySpec parameter handling
2020-02-06 17:57:00 +01:00
Bert Blommers
7719ac76a3
Merge pull request #2720 from jrbeilke/feature-apigw-defaults
...
Feature apigw defaults
2020-02-06 13:52:56 +00:00
Bert Blommers
58b3304310
Merge pull request #2729 from grodzik/add-update-organizational-unit-endpoint
...
Add update organizational unit endpoint
2020-02-06 13:51:30 +00:00
Paweł Tomak
fc9eab2591
Raise DuplicateOrganizationalUnitException
...
Calling UpdateOrganizationalUnit with name that already exists should
raise proper error.
2020-02-06 12:38:37 +01:00
Paweł Tomak
14ebf29a61
Add UpdateOrganizationalUnit endpoint to Organizations API
2020-02-06 11:49:41 +01:00
Brady
ecdedf30c8
force build...
2020-02-05 16:31:33 -05:00
Brady
c95254a284
delete tags when their resource is deleted
2020-02-05 11:58:52 -05:00
Bert Blommers
fa17b748f5
Merge pull request #2724 from jayudey-vertex/account-for-types
...
Handle map or list parameters in sns processing
2020-02-05 16:13:59 +00:00
Brady
414f8086b0
use sure for unit test assertions
2020-02-05 10:30:59 -05:00
Jay Udey
1321943d60
add test verifying solution
2020-02-05 09:03:45 -06:00
Ivan Dromigny
d8d057711d
Change from black linter
2020-02-05 14:19:08 +01:00
Ivan Dromigny
8115dd2d1b
Add test
2020-02-05 12:03:33 +01:00
Mike Grima
bb64258a8f
Fixed issue with Lambda invoke via ARN
...
- Fixed an issue where Lambda invokes via an ARN was hitting real AWS.
2020-02-04 22:12:11 -08:00
Jon Beilke
c9995412b5
add support for apigateway fields with default values including apiKeySource, endpointConfiguration, and tags
2020-02-03 10:21:22 -06:00
Bert Blommers
70b2d3ab3c
Merge pull request #2709 from blbradley/fix/localstack-split-stacks
...
throw ValidationError on non existing stack
2020-02-03 14:33:54 +00:00
Bert Blommers
e4eede7f9b
Merge pull request #2718 from gmcrocetti/bugfix/2690
...
RDS Feature: Add EnableIAMDatabaseAuthentication
2020-02-02 18:01:21 +00:00
Guilherme Martins Crocetti
9f8388e402
Change test name in favor of abbreviation
2020-02-02 13:19:50 -03:00
Guilherme Martins Crocetti
eb0687eeaa
Add failing test for EnableIAMDatabaseAuthentication snapshot
2020-02-02 13:08:13 -03:00
Guilherme Martins Crocetti
c36371e235
Add failing test for database creation with iam
2020-02-02 12:47:54 -03:00
Bert Blommers
e21ddb7abc
Use var instead of hardcoded string for region
2020-02-02 14:25:44 +00:00
Bert Blommers
ceb16b00a7
S3 LocationConstraint test can only be run in non-ServerMode
2020-02-02 12:45:57 +00:00
Bert Blommers
d5a36752d7
Add S3 LocationConstraint to CF tests
2020-02-02 12:44:26 +00:00
Bert Blommers
a86cba79de
Add S3 LocationConstraint to Lambda tests
2020-02-02 11:48:32 +00:00
Bert Blommers
f74f08581a
S3 - Add IllegalLocationConstraint validation when creating buckets
2020-02-02 10:36:51 +00:00
gruebel
40bd4f1603
Fix kms.create_key default output
2020-01-31 17:16:42 +01:00
Bert Blommers
b6aeae0f2d
Merge pull request #2707 from UltCombo/patch-1
...
Support greedy resource path in API Gateway
2020-01-31 15:27:35 +00:00
Brandon Bradley
8b3c2b6654
fix test
2020-01-30 17:50:21 -06:00
Brandon Bradley
b7795b7111
test for ListStackResources
2020-01-30 16:35:19 -06:00
gruebel
44024ab74b
Fix sqs permission handling & add more error handling
2020-01-30 22:42:27 +01:00
Fabrício Matté
cf65cfc6ec
Update API Gateway resource name test
2020-01-29 16:28:37 -03:00
Bert Blommers
da40c7125a
Merge pull request #2703 from brady-gsa/fix_lambda_config
...
Fixes awslambda policy management
2020-01-29 15:30:25 +00:00
Brady
dd243d72c2
switch to using sure for assertions
2020-01-29 09:46:09 -05:00
Bert Blommers
3cf45b7838
Merge pull request #2667 from owenfarrell/master
...
Made UserName parameter optional for IAM access key functions
2020-01-28 08:24:12 +00:00
Owen Farrell
142e237b0b
Made UserName parameter optional for IAM access key functions
2020-01-27 12:12:21 -05:00
Brady
cb07d17e13
don't use table of test cases and reduce duplication in get_policy method
2020-01-27 10:35:46 -05:00
Bert Blommers
4342b93170
Merge pull request #2702 from kislyuk/patch-5
...
awslambda: return actual result in sync invoke
2020-01-25 17:24:37 +00:00
Brady
2a2ff32dec
improves support for AWS lambda policy management
2020-01-24 14:53:16 -05:00
Andrey Kislyuk
324ef5af36
Fix test
2020-01-24 16:11:44 +00:00
Bert Blommers
ccd0257acc
Fix Lambda tests for DryRuns
2020-01-24 10:09:56 +00:00
Stephan Huber
5543a91cc1
Merge remote-tracking branch 'upstream/master'
2020-01-24 10:38:19 +01:00
Bert Blommers
ee8231202a
Fix linting
2020-01-24 09:08:48 +00:00
Roque Pinel
2ae09c5335
Fix the StatusCode
returned by lambda invoke
...
According to the AWS documentation:
```
The HTTP status code will be in the 200 range for successful request.
For the RequestResponse invocation type this status code will be 200.
For the Event invocation type this status code will be 202.
For the DryRun invocation type the status code will be 204.
```
2020-01-24 09:07:49 +00:00
Asher Foa
b4127040d1
remove this change.
2020-01-23 10:16:12 -08:00
Asher Foa
d9d055c75d
Fix more typos.
2020-01-23 10:15:02 -08:00
Stephan Huber
20020c5170
Change whitespaces back to the way they were and fix typos
2020-01-23 15:46:50 +01:00
Stephan Huber
84210f6011
Merge remote-tracking branch 'upstream/master'
2020-01-23 15:37:40 +01:00
Steve Pulec
663d7c289b
Merge pull request #2675 from bblommers/bugfix/#2674
...
DynamoDB - ListAppend should also work when adding maps to a list
2020-01-22 20:01:53 -06:00
Steve Pulec
c5b7b2f7af
Merge pull request #2687 from bblommers/bugfix/2626
...
DynamoDB - Update Item doesnt handle LT/GT properly
2020-01-22 20:01:00 -06:00
Steve Pulec
dff1986801
Merge pull request #2683 from Journera/ecs-td-add-network-mode
...
Store 'networkMode' in ECS Task Definitions instead of just throwing it away
2020-01-22 19:39:41 -06:00
Steve Pulec
a32b3c4b59
Fix SQS get_queue_attributes to allow RedrivePolicy. Closes #2682 .
2020-01-22 19:38:07 -06:00
Bert Blommers
7ff7ee4e8e
Test fix - Region must be specified
2020-01-22 11:42:06 +00:00
Bert Blommers
6f02782624
#2627 - Change comparison to differentiate between 0 and None
2020-01-22 11:30:17 +00:00
Steve Pulec
4335f1d3dd
Merge pull request #2669 from bblommers/lambda-return-output-only
...
AWS Lambda - Return response only, and skip log/print statements
2020-01-21 21:37:36 -06:00
Brady
1e851fb1d8
remove dead code
2020-01-17 10:12:58 -05:00
Brady
eaa8c8db6e
add tagging support to events
2020-01-16 21:03:32 -05:00
Bryan Alexander
85207b885b
updates KMS service to use TaggingService
2020-01-16 12:10:38 -06:00
Bert Blommers
1c4596c984
Merge pull request #2671 from franz-see/moto/issues/2670
...
moto/issues/2670 | Moved population of user attributes from accessToken to idToken
2020-01-16 05:57:17 +00:00
Bryan Alexander
6cb0428d20
adds tagging support for cloudwatch events service
2020-01-15 10:41:54 -06:00
Bert Blommers
a50d0695fe
Merge pull request #2661 from deanrock/route53-rrs-istruncated
...
Add IsTruncated to Route53.list_resource_record_sets
2020-01-15 15:39:09 +00:00
Franz See
db75c9e25c
moto/issues/2670 | Moved population of user attributes from accessToken to idToken
2020-01-15 23:33:09 +08:00
Bert Blommers
15889566b8
Merge pull request #2673 from franz-see/moto/issues/2672
...
moto/issues/2672 | Modified 'token_use' to return 'id' for an id toke…
2020-01-15 14:54:52 +00:00
Asher Foa
db559e7e06
Fix some typos
2020-01-14 09:55:32 -08:00
Bert Blommers
8c920cce10
Specify region in tests
2020-01-12 12:20:55 +00:00
Bert Blommers
9ce1ee49d7
#2626 - DynamoDB - FilterExpression should ignore items with non-existent attribute
2020-01-12 12:05:08 +00:00
Don Kuntz
fd1fdde1bf
Allow black to reformat correctly
2020-01-09 23:45:14 -06:00
Don Kuntz
2cb3f327de
Store 'networkMode' in ECS Task Definitions instead of just throwing it away
2020-01-09 23:00:33 -06:00
Bert Blommers
5884483019
Compare map, instead of string repr
2020-01-09 10:08:35 +00:00
Bert Blommers
cba3cfc384
Escape curly braces in formatting string
2020-01-09 09:10:16 +00:00
Bert Blommers
5f59cb7fb0
#2674 - ListAppend should also work when adding maps to a list
2020-01-06 08:16:09 +00:00
Franz See
a8e1a3bf08
moto/issues/2672 | Formatted using black
2020-01-06 13:29:23 +08:00
Franz See
68d882e6c0
moto/issues/2672 | Modified 'token_use' to return 'id' for an id token, and 'access' for an access token
2020-01-06 00:19:31 +08:00
Bert Blommers
eab9e15bf0
#2623 - Fix and simplify test in ServerMode
2020-01-05 15:01:31 +00:00
Jack Danger
d596560971
Merge pull request #2657 from gruebel/add-missing-regions
...
Add missing regions to all services
2020-01-02 17:27:25 -08:00
gruebel
cd9b7072a2
Adjust ec2 regions tests
2019-12-28 21:22:16 +01:00
Dejan Levec
877f3b056a
Add IsTruncated to Route53.list_resource_record_sets
2019-12-27 19:32:31 +01:00
Mike Grima
1db617a530
Merge pull request #2659 from gruebel/fix-sns-unsubscribe
...
Fix sns unsubscribe & delete_topic behavior
2019-12-27 09:10:24 -08:00
Mike Grima
d0d95420e7
Merge pull request #2655 from levinine/add-codecommit
...
add codecommit create, get and delete repository
2019-12-27 09:04:19 -08:00
Mike Grima
b86e1d073b
Merge pull request #2652 from gruebel/add-codepipeline-tags
...
Add codepipeline tags
2019-12-27 08:57:59 -08:00
Mike Grima
79aaad1068
Merge pull request #2651 from whummer/fix-s3-prefix
...
Avoid rendering "None" as S3 Prefix value
2019-12-27 08:56:06 -08:00
Mike Grima
eeedb2e6f8
Merge pull request #2650 from asherf/dynanmodb
...
Fix issue when working with dyanmodb stream and complex types.
2019-12-27 08:54:47 -08:00
Mike Grima
65664dcf85
Merge pull request #2648 from asherf/iam
...
Implement List user tags
2019-12-27 08:53:05 -08:00
Mike Grima
664e959856
Merge pull request #2639 from corrjo/instance_connect
...
Resolves #2637 added send_ssh_public_key
2019-12-27 08:51:27 -08:00
gruebel
2fb5004dc2
Fix sns unsubscribe & delete_topic behavior
2019-12-27 16:04:12 +01:00
gruebel
d7ba355a65
Add missing regions to all services
2019-12-26 17:12:22 +01:00
Jovan Zivanov
cb1eb79b89
add tests for codecommit
2019-12-26 16:06:53 +01:00
Jovan Zivanov
e20deb4acd
fix linter exceptions
2019-12-26 15:02:24 +01:00
Jovan Zivanov
a820aada42
add codecommit create, get and delete repository
2019-12-26 14:23:53 +01:00
Asher Foa
7d4c15d53e
skip part of the test in server mode.
2019-12-24 11:01:54 -08:00
Asher Foa
299e7851d6
Add assertions.
2019-12-24 10:23:46 -08:00
gruebel
8331d480ba
Add codepipeline.untag_resource
2019-12-23 19:50:16 +01:00
gruebel
b96a46b98f
Add codepipeline.tag_resource
2019-12-23 19:33:37 +01:00
Stephan Huber
ed8d5edb50
fix linting errors
2019-12-23 09:01:53 +01:00
Stephan Huber
0527e88d46
Merge remote-tracking branch 'upstream/master'
2019-12-23 08:38:53 +01:00
gruebel
df951facc5
Add codepipeline.list_tags_for_resource
2019-12-22 11:42:15 +01:00
Waldemar Hummer
4ad111830b
fix tests
2019-12-21 13:27:49 +01:00
Asher Foa
5bd3827b26
run black
2019-12-20 18:55:58 -08:00
Asher Foa
a6f14eee3f
Add test to repo stream issue
2019-12-20 18:55:58 -08:00
Asher Foa
c2e444a210
Update tests.
2019-12-20 10:54:33 -08:00
Mike Grima
b8a1f85285
Merge pull request #2644 from gruebel/add-codepipeline-fix
...
CodePipeline - implement CRUD endpoints
2019-12-20 09:28:42 -08:00
gruebel
901be3a6d1
Remove unused import
2019-12-20 10:54:38 +01:00
Asher Foa
1415a93596
Implement List user tags
2019-12-19 19:45:56 -08:00
gruebel
a67660b8a4
Adjust tests to work in server mode
2019-12-19 21:41:32 +01:00
John Corrales
199ff05e4e
parent 0f67a74d25
...
author John Corrales <jjcorrales3@gmail.com> 1576380101 -0800
committer John Corrales <jjcorrales3@gmail.com> 1576633072 -0800
added send_ssh_public_key
2019-12-17 17:38:49 -08:00
Mike Grima
91983b4823
Merge pull request #2610 from gruebel/fix-sns-get-subscription-attributes
...
Add missing attributes to SNS subscription
2019-12-17 08:36:59 -08:00
gruebel
03fd04db33
Use pytz instead of timezone
2019-12-17 17:22:46 +01:00
gruebel
8e03b1d525
Add codepipeline.delete_pipeline
2019-12-17 17:22:46 +01:00
gruebel
9871eda3c9
Add codepipeline.list_pipelines
2019-12-17 17:22:46 +01:00
gruebel
b2c44ce50d
Add codepipeline.update_pipeline
2019-12-17 17:22:45 +01:00
gruebel
c84e465e4c
Add codepipeline.get_pipeline
2019-12-17 17:22:45 +01:00
gruebel
076c8ace5f
Add codepipeline.create_pipeline
2019-12-17 17:22:45 +01:00
Fabio Dias
743dd46399
black linting
2019-12-16 21:25:20 -05:00
Fabio Dias
fd9ac4b9a5
ACCOUNT_ID moved to moto.core, MOTO_ACCOUNT_ID env var override
2019-12-16 21:05:29 -05:00
Fabio Dias
bc615797b1
typo
2019-12-16 19:56:11 -05:00
Fabio Dias
b83a750630
Added references to moto.iam.models.ACCOUNT_ID instead of hardcoded id
2019-12-16 19:56:11 -05:00
Mike Grima
65b17e740d
Merge pull request #2611 from Sytten/fix/ssm-parameter
...
Add missing information in SSM parameters
2019-12-16 11:59:42 -08:00
Mike Grima
8e2e3cec5a
Merge pull request #2597 from ballwood/master
...
Add MaxSessionDuration field to IAM Role, Remove Description field from response if empty
2019-12-14 13:47:28 -08:00
Mike Grima
7b63b2818e
Merge pull request #2631 from kislyuk/patch-2
...
Batch: computeResources.instanceRole is an instance profile
2019-12-14 13:46:08 -08:00
Mike Grima
fb350bbcef
Merge pull request #2632 from kislyuk/patch-3
...
Batch: job definitions default to ACTIVE
2019-12-13 13:33:56 -08:00
Andrey Kislyuk
624dafcb5c
Fix tests
2019-12-13 18:46:26 +00:00
Andrey Kislyuk
777ff5a62a
Add test
2019-12-13 05:07:29 +00:00
Mike Grima
4386999ea7
Merge pull request #2613 from levinine/add_nat_gateway_id_to_route_and_describe_route_tables
...
Add nat_gateway_id to route and describe_route_tables
2019-12-12 18:33:11 -08:00
Mike Grima
ab73ab3ff5
Merge pull request #2609 from levinine/describe_nat_gateway_filter_support
...
Add describe_nat_gateway filters support
2019-12-12 18:29:05 -08:00
Mike Grima
61f28c308d
Merge pull request #2608 from aksagrimada/ssm_pagination
...
Add Pagination to ssm:get_parameters_by_path. Closes #1864
2019-12-12 18:22:33 -08:00
Mike Grima
8399bc4df5
Merge pull request #2606 from levinine/api_key_fix
...
api gateway handle duplicate api key values
2019-12-12 18:21:51 -08:00
Mike Grima
9f73a67cef
Merge pull request #2583 from trilliput/issue/1996
...
Improve parsing DynamoDB begins_with expression
2019-12-12 18:19:27 -08:00
Mike Grima
84ccdbd1cd
Implemented S3 Public Access Block
2019-12-12 17:45:31 -08:00
Ilya Shmygol
704a12146b
Improve error reporting for missing index
2019-12-12 10:49:07 +01:00
Ilya Shmygol
3a42079ec7
Merge remote master
2019-12-11 16:17:21 +01:00
Ilya Shmygol
be5986c0b5
Test query by non exists index
2019-12-11 15:08:45 +01:00
Mike Grima
4d5bf1c5c6
Merge pull request #2605 from bblommers/dynamodb_add_nested_stringsets
...
Dynamodb - DELETE/ADD item from/to nested sets
2019-12-09 14:14:56 -08:00
Mike Grima
c131dd2cac
Merge pull request #2604 from gruebel/fix-logs-get-log-events
...
Fix order and nextToken handling in logs.get_log_events
2019-12-09 14:14:11 -08:00
Mike Grima
872452eced
Merge pull request #2602 from atareshawty/ecs-list-task-definition-filtering
...
Add familyPrefix option to ecs:ListTaskDefinitions
2019-12-09 14:13:14 -08:00
Mike Grima
7e68b93091
Merge pull request #2601 from mwaaas/fix/get_policy
...
adding get policy endpoint
2019-12-09 14:11:50 -08:00
Mike Grima
1c5ea4b545
Merge pull request #2599 from bblommers/feature/#2010
...
CloudWatch - Implement list_metrics pagination
2019-12-09 14:11:05 -08:00
Mike Grima
90f5f7159d
Merge pull request #2598 from bblommers/feature/dynamodb_nested_list_append
...
Dynamodb: nested list_append
2019-12-09 14:10:00 -08:00
Mike Grima
b2264feac5
Merge pull request #2596 from gruebel/fix-ec2-revoke-security-group-egress
...
Fix ec2.revoke_security_group_egress for IpProtocol -1
2019-12-09 14:06:09 -08:00
Mike Grima
76aaa2df0f
Merge pull request #2595 from bblommers/feature/2317
...
Add CF update/delete methods for Lambda
2019-12-09 14:04:49 -08:00
Mike Grima
e00c12a1e6
Merge pull request #2594 from mwaaas/fix/fetch_secret_manage_via_arn
...
fixing fetch secret manager via arn
2019-12-09 14:03:37 -08:00