Commit Graph

97 Commits

Author SHA1 Message Date
usmangani1
b2adcdf518
Fix:RDS:add DBParameterGroupArn in describe-db-parameter-groups & cre… (#3462)
* Fix:RDS:add DBParameterGroupArn in describe-db-parameter-groups & create-db-parameter-group

* Test change

* Fixed tests

* tests change acconutID

* linting

Co-authored-by: usmankb <usman@krazybee.com>
2020-12-01 19:53:01 +00:00
Brian Pandola
d29475ed19
Fix: TagList missing in rds:DescribeDBInstance response (#3459)
Previously, tags were only available via rds:ListTagsForResource, but are now
included in the Create/DescribeDBInstance responses as of Botocore 1.18.17[1]

[1]: f29d23c53e (diff-d10722c0e11ded323c8d240066d7ed31e93a1e6423d54e091b7d54b86e6bd4e0)

Fixes #3458
2020-11-16 09:30:53 +00:00
jweite
49d92861c0
Iam cloudformation update, singificant cloudformation refactoring (#3218)
* IAM User Cloudformation Enhancements: update, delete, getatt.

* AWS::IAM::Policy Support

* Added unit tests for AWS:IAM:Policy for roles and groups.  Fixed bug related to groups.

* AWS:IAM:AccessKey CloudFormation support.

* Refactor of CloudFormation parsing.py methods to simplify and standardize how they call to the models.  Adjusted some models accordingly.

* Further model CloudFormation support changes to align with revised CloudFormation logic.  Mostly avoidance of getting resoure name from properties.

* Support for Kinesis Stream RetentionPeriodHours param.

* Kinesis Stream Cloudformation Tag Support.

* Added omitted 'region' param to boto3.client() calls in new tests.

Co-authored-by: Joseph Weitekamp <jweite@amazon.com>
2020-08-27 10:11:47 +01:00
Adam Richie-Halford
9a9a1d8413
Decentralize cloudformation naming responsibilities (#3201)
* #3127 - Decentralize CF naming responsibilities

* Decentralize CloudFormation naming responsibilities

* Update URLs in cloudformation_resource_type functions

* Fix flake8 errors

* Black formatting

* Add a bunch of imports to populate CloudFormationModel.__subclasses__

* Add noqa to s3 models import statement in cloudformation/parsing.py

* Black formatting

* Remove debugging print statement

Co-authored-by: Bert Blommers <info@bertblommers.nl>
2020-08-01 15:23:36 +01:00
Stijn Seghers
9c13798f78
Fix import errors
For Python 2, the lazy importing style uncovered some importing
mistakes. I can't quite figure out how it was working before.
2020-04-28 10:40:34 +12:00
Hugo Lopes Tavares
4dc46a697d Bugfix: Allow stop_db_instance for compatible engines
From the RDS documentation:
    You can stop and start a DB instance whether it is configured for a single Availability Zone or for Multi-AZ, for database engines that support Multi-AZ deployments. You can't stop an Amazon RDS for SQL Server DB instance in a Multi-AZ configuration.

https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_StopInstance.html#USER_StopInstance.Limitations
2020-04-16 15:14:37 -04:00
Guilherme Martins Crocetti
f0509276d8 Apply black in responses.py 2020-02-02 13:46:01 -03:00
Guilherme Martins Crocetti
06e4cafd20 Add enable_iam_database_authentication variable into snapshot 'to_xml' 2020-02-02 13:10:04 -03:00
Guilherme Martins Crocetti
51e787fba6 Add enable_iam_database_authentication in 'to_xml' method 2020-02-02 12:57:16 -03:00
Guilherme Martins Crocetti
dfd21187e1 Change iam_database_authentication_enabled to enabled_iam_database_authentication in accordance with aws docs 2020-02-02 12:55:05 -03:00
Guilherme Martins Crocetti
ec66670315 Add enable_iam_database_authentication parameter in RDS2Response 2020-02-02 12:50:46 -03:00
Asher Foa
d9d055c75d Fix more typos. 2020-01-23 10:15:02 -08:00
gruebel
9d9b620878 Fixed linter errors 2019-12-26 21:03:49 +01:00
gruebel
d7ba355a65 Add missing regions to all services 2019-12-26 17:12:22 +01:00
Asher Foa
96e5b1993d Run black on moto & test directories. 2019-10-31 10:36:05 -07:00
Chih-Hsuan Yen
84fb52d0a2
Fix remaining flake8 issues
Disabling W504 and W605 for now as there are too many instances.
2019-10-27 21:00:01 +08:00
Stephen Huff
d1a13ed782 chore(rds2): make flake8 happy 2019-10-16 09:10:56 -04:00
Stephen Huff
7b1cf9eecd fix(rds2): handle create_db_instance when AllocatedStorage is not specified
In all of the tests of `create_db_instance()`, the `AllocatedStorage`
parameter is provided.  The [RDS API
reference](https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_CreateDBInstance.html)
says this parameter is optional; however, when none is provided, moto
returns an obscure error message:

```
self = <botocore.parsers.QueryParser object at 0x113745890>, shape = <Shape(Integer)>, text = 'None'

    @_text_content
    def _handle_integer(self, shape, text):
>       return int(text)
E       ValueError: invalid literal for int() with base 10: 'None'

/usr/local/Cellar/pyenv/1.2.13_1/versions/3.7.4/envs/rds_encrypt/lib/python3.7/site-packages/botocore/parsers.py:466: ValueError
```

This PR adds default values that correspond to the current default API
behaviors.
2019-10-15 16:18:37 -04:00
Jongseok Choi
5d91ce20fc Fix 'MaxRecords' type issues by _get_param()
It alternates _get_param() with _get_int_param() on parsing the
parameter 'MaxRecords'.
2019-07-18 03:09:53 +09:00
Berislav Kovacki
4ed189c454 Add support for VpcSecurityGroups set/update in RDS 2019-07-13 08:19:23 +02:00
Berislav Kovacki
4fd0b5c710 Add support for OptionGroupName in create_db_instance 2019-07-11 22:43:42 +02:00
Berislav Kovacki
c51ce76ee9 Add InstanceCreateTime to DBInstance 2019-07-09 02:10:33 +02:00
Jon Beilke
67a0e06059 allow for adding and removing tags on rds snapshots 2018-09-21 13:54:07 -05:00
Jon Beilke
245e3a5f71 formatting fix for E111 indentation is not a multiple of four 2018-09-21 13:33:10 -05:00
Jon Beilke
7daee905a5 remove merge_taglists as AWS will only take submitted tags or tags from db but not both when creating snapshot 2018-09-21 13:28:13 -05:00
Jon Beilke
6eb490ac78 add support for tags to rds snapshots 2018-09-21 12:03:13 -05:00
Jon Beilke
1b8b32a663 add CopyTagsToSnapshot to db_kwargs 2018-09-21 11:13:33 -05:00
Jon Beilke
276da06168 added new merge_taglists() to moto.core.utils for merging lists of tags with precedence (ie. during rds2.create_snapshot) 2018-09-21 10:39:42 -05:00
Jon Beilke
881afc8f4a update RDS models to include CopyTagsToSnapshot 2018-09-21 08:31:31 -05:00
Steve Pulec
23b51c39a1
Merge pull request #1585 from bpandola/fix-1569
Fix rds.describe_db_snapshots bugs
2018-05-30 23:10:20 -04:00
Brian Pandola
37d6388640 Fix rds.describe_db_snapshots bugs
* Correctly return all snapshots for a given DBInstanceIdentifier.
* If an invalid DBInstanceIdentifier is passed in, return an empty array
  instead of raising a ClientError (which is what AWS actually does).

Fixes #1569
2018-04-19 20:21:27 -07:00
Steve Pulec
311966e28d Add IAMDatabaseAuthenticationEnabled and DbiResourceId to RDS response. Closes #1465. 2018-04-18 22:47:02 -04:00
Koudai Aono
518282dbd3 change get_param method to get_int_param 2018-01-25 00:51:14 +09:00
Koudai Aono
e4cf58d6fa cast MaxRecords to int on describe_db_instances 2018-01-25 00:51:14 +09:00
Ben Slusky
796fa6647b modify_db_instance should be able to rename DB instances (#1367) 2017-11-30 11:41:25 +00:00
justinsr20
17b8396a9c updated rds status from shutdown to stopped to match aws (#1347) 2017-11-20 09:07:36 +00:00
Terry Cain
596bf84480
Fixed typo 2017-10-25 20:14:39 +01:00
Terry Cain
9ddf7fe436
Fixed some tests.
Some subnets were bogus so fixed that. Fixed issue where EC2-Classic was not respected.
RDS Deepcopy was breaking on subnet generator
2017-10-25 19:29:56 +01:00
rocky4570fft
1c1ef9dc25 the linter is too linty 2017-08-15 00:58:33 +10:00
rocky4570fft
c84e8c86f0 modify to use create_snapshot, add extra tests for certain error conditions 2017-08-15 00:55:09 +10:00
rocky4570fft
f2cc60b999 satisfy the flake tests - doesnt like my flakey code :( 2017-08-14 00:41:26 +10:00
rocky4570fft
85dd2440f4 oopsie on api version dates for delete and create snapshot_templates, should be on stop/start rds instances 2017-08-14 00:32:08 +10:00
rocky4570fft
ed39c2ea4e fix up some issues found in unittests - comment out snapshotting until later 2017-08-14 00:27:15 +10:00
rocky4570fft
9687b6e03e get appropritate parameters - doh 2017-08-13 12:05:22 +10:00
rocky4570fft
6c3c6623bf should only call create_snapshot if db_snapshot_identifier is filled 2017-08-13 12:02:49 +10:00
rocky4570fft
7afd3532c6 fixup typos and cleanup code a little 2017-08-13 12:00:21 +10:00
rocky4570fft
ecf77d64cd add rds stop-start 2017-08-13 11:52:27 +10:00
Jack Danger Canty
c3d9f4e056 Persisting selected LicenseModel in RDS instances 2017-07-05 16:02:45 -07:00
Jack Danger Canty
e57798cb96 Implementing snapshots on rds instance deletion 2017-06-20 14:46:13 -07:00
Jack Danger Canty
8df7169915 Snapshots are optional 2017-06-20 14:01:30 -07:00