Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
8,296 Commits 1 Branch 0 Tags
Commit Graph

161 Commits

Author SHA1 Message Date
aantillonl
d382731a14
Remove duplicate template of SNS error response (#3647) 
In e9dc5edf7fafeb677bc3d720c6e2c3dfc8f3460e a custom error template
was added to correct the response returned by get_endpoint_attributes
for a non-existent endpoint.

However, after some more inspection, it was found that a valid
template already existed in moto/sns/responses.py.

This commit removes the template introduced in e9dc5ed and takes
into use the existing template.

It is a marginal improvement, but helps keeping a cleaner code
base

Co-authored-by: Antillon, Alejandro <alejandro.antillon@f-secure.com>
 2021-02-01 14:58:48 +00:00
aantillonl
e9dc5edf7f
Update SNS get_endpoint_attributes response for Not Found endpoints (#3637) 
The response returned for sns.get_endpoint_attributes was not in
sync with the actual response from boto.

Co-authored-by: Antillon, Alejandro <alejandro.antillon@f-secure.com>
 2021-01-31 12:29:10 +00:00
usmangani1
651998853b
Fix:SNS Create FIFO Topic (#3533) 
* Fix:SNS Create FIFO Topic

* Added more tests

* change regular expression and added tests

* Handling NPE

Co-authored-by: usmanokc <usman@okcredit.in>
 2021-01-26 15:04:52 +00:00
Pavel
c9c30b8286
Enabled SNS endpoint attr must be lowercased (#3543) 
As per sample response:
https://docs.aws.amazon.com/sns/latest/api/API_GetEndpointAttributes.html
 2020-12-14 15:08:33 +00:00
usmangani1
19fc76f466
Fix: SNS Delete subscriptions on topic deletion (#3410) 
* Fix:Delete subscriptions on delete topic

* Changed tests

Co-authored-by: usmankb <usman@krazybee.com>
 2020-10-29 08:52:02 +00:00
Brian Pandola
28c1690fc2
Add Support for SNS Topic KmsMasterKeyId Attribute (#3389) 
We do not do any validation of the `KmsMasterKeyId` attribute, and simply
store it as-as.  This mimics the behavior in AWS, where the key is not
validated until it is actually used (when publishing[1]).

[1]: https://docs.aws.amazon.com/sns/latest/dg/sns-server-side-encryption.html

Closes #3216
 2020-10-16 12:30:07 +01:00
Daniel Okey-Okoro
c321ad46b0
fix: deleting non-existent topic shouldn't raise KeyError (#3285) 2020-09-10 08:32:41 +01:00
jweite
49d92861c0
Iam cloudformation update, singificant cloudformation refactoring (#3218) 
* IAM User Cloudformation Enhancements: update, delete, getatt.

* AWS::IAM::Policy Support

* Added unit tests for AWS:IAM:Policy for roles and groups.  Fixed bug related to groups.

* AWS:IAM:AccessKey CloudFormation support.

* Refactor of CloudFormation parsing.py methods to simplify and standardize how they call to the models.  Adjusted some models accordingly.

* Further model CloudFormation support changes to align with revised CloudFormation logic.  Mostly avoidance of getting resoure name from properties.

* Support for Kinesis Stream RetentionPeriodHours param.

* Kinesis Stream Cloudformation Tag Support.

* Added omitted 'region' param to boto3.client() calls in new tests.

Co-authored-by: Joseph Weitekamp <jweite@amazon.com>
 2020-08-27 10:11:47 +01:00
Kamil Mańkowski
8a551a9754
[SNS] Mock sending directly SMS (#3253) 
* [SNS] Mock sending directly SMS

Proper behaviour when publishing to PhoneNumber is sending
message directly to this number, without any topic or
previous confirmation.

https://docs.aws.amazon.com/sns/latest/dg/sns-mobile-phone-number-as-subscriber.html

* Fix arguments order

* Omit checking local backend when tests in server mode
 2020-08-25 13:05:49 +01:00
Adam Richie-Halford
9a9a1d8413
Decentralize cloudformation naming responsibilities (#3201) 
* #3127 - Decentralize CF naming responsibilities

* Decentralize CloudFormation naming responsibilities

* Update URLs in cloudformation_resource_type functions

* Fix flake8 errors

* Black formatting

* Add a bunch of imports to populate CloudFormationModel.__subclasses__

* Add noqa to s3 models import statement in cloudformation/parsing.py

* Black formatting

* Remove debugging print statement

Co-authored-by: Bert Blommers <info@bertblommers.nl>
 2020-08-01 15:23:36 +01:00
Macwan Nevil
6adee0cbaf
Bugfix: RedrivePolicy Issue SNS (#3186) 
* Bugfix: S3 time precision issue fixed

* Bugfix: S3 time precision issue fixed

* s3 timeformat fix

* Quickfix S3 timefix

* Bugfix: Redrive Policy Allow

* Linting Fixed
 2020-07-27 18:53:15 +01:00
gruebel
23dfecc845 Fix missing MessageAttributes when using RawMessageDelivery 2020-03-21 19:25:25 +01:00
Jack Danger
d596560971
Merge pull request #2657 from gruebel/add-missing-regions 
Add missing regions to all services
 2020-01-02 17:27:25 -08:00
gruebel
2fb5004dc2 Fix sns unsubscribe & delete_topic behavior 2019-12-27 16:04:12 +01:00
gruebel
d7ba355a65 Add missing regions to all services 2019-12-26 17:12:22 +01:00
Mike Grima
91983b4823
Merge pull request #2610 from gruebel/fix-sns-get-subscription-attributes 
Add missing attributes to SNS subscription
 2019-12-17 08:36:59 -08:00
Fabio Dias
743dd46399 black linting 2019-12-16 21:25:20 -05:00
Fabio Dias
fd9ac4b9a5 ACCOUNT_ID moved to moto.core, MOTO_ACCOUNT_ID env var override 2019-12-16 21:05:29 -05:00
Fabio Dias
b83a750630 Added references to moto.iam.models.ACCOUNT_ID instead of hardcoded id 2019-12-16 19:56:11 -05:00
gruebel
deaeef521b Add missing attributes to SNS subscription 2019-11-30 15:51:43 +01:00
Asher Foa
3bb31c84fd Fix some typos 2019-11-16 12:31:45 -08:00
gruebel
3d5d477f7f Fix sns.publish with number type and 0 value 2019-11-16 14:46:05 +01:00
gruebel
58daa428f3 Fix sns.subscribe validation for sms numbers 2019-11-04 22:57:53 +01:00
Asher Foa
96e5b1993d Run black on moto & test directories. 2019-10-31 10:36:05 -07:00
gruebel
6b7294a018 Fix sns.add_permission & remove_permission 2019-10-25 17:57:50 +02:00
Mike Grima
4da9ec1346
Merge pull request #2442 from titibike/sns_subscription_attributes 
Issue #2441 Add informations in SNS subscriptions `attributes`
 2019-10-15 10:05:20 -07:00
gruebel
26ef792690 Add sns.untag_resource 2019-10-12 21:10:51 +02:00
gruebel
726775678c Add sns.tag_resource 2019-10-12 20:37:59 +02:00
gruebel
8d527743d5 Add sns.list_tags_for_resource 2019-10-11 17:58:48 +02:00
Ivan Dromigny
03986df929 Update syntax 2019-10-03 09:53:04 +02:00
Ivan Dromigny
83c8740b91 Add informations in subscriptions attributes 2019-10-02 18:06:34 +02:00
Steve Pulec
8867e91f9e
Merge pull request #2391 from gruebel/master 
Add exact Number, exact String.Array and attribute key matching to SN…
 2019-09-11 21:46:06 -05:00
gruebel
d8a922811c Add exact Number, exact String.Array and attribute key matching to SNS subscription filter policy and validate filter policy 2019-08-25 21:08:02 +02:00
Randy Westergren
ccceb70397
And event source mapping endpoints and SQS trigger support 2019-08-20 21:54:57 -04:00
Steve Pulec
ac33845367
Merge pull request #2070 from bkovacki/add-attributes-parameter-for-sns-create_topic-api 
Add attributes parameter support for sns create_topic API
 2019-07-07 23:04:40 -05:00
Brian Engen
6838d7964f handles empty string in SNS next token (#2177) 2019-05-25 10:24:46 +01:00
Berislav Kovacki
7e863b0260 Add attributes parameter support for sns create_topic API 2019-02-21 22:08:46 +01:00
Michael Bell
51db19067c Allow attributes to be set with subscribe command (#1705) 2018-07-13 10:21:33 +01:00
Iain Bullard
cd4dd3cfbf SNS - Enforce 'Message too long' exception when publishing messages 2018-06-04 13:38:58 +00:00
hsuhans
d9a4501d24 Change SNS http header to actual setting 2018-06-02 06:18:27 +08:00
Steve Pulec
b6909ff64c
Merge pull request #1654 from Birne94/sns-raw-message-delivery 
Add RawMessageDelivery for SNS subscriptions (fixes #1571)
 2018-05-30 09:46:59 -04:00
Daniel Birnstiel
222cb1535c Add RawMessageDelivery for SNS subscriptions (fixes #1571) 2018-05-30 09:30:18 +02:00
Ben Jolitz
289d361463 add check for at least 1 character as the minumum length 
REF: http://boto3.readthedocs.io/en/latest/reference/services/sns.html#SNS.Client.create_topic
 2018-05-04 19:17:37 -07:00
Ben Jolitz
0ed18c8b8a remove extraneous backslash 2018-05-04 16:33:43 -07:00
Ben Jolitz
b08fc8bede
allow topic names to start/end with _, - 2018-05-04 16:30:47 -07:00
wblackconv
ba2ea8e1b3 Add tests for message attribute validation in SNS (#1582) 
* Add tests for message attribute validation in SNS

Fixes up bug in return value of
moto.sns.responses.SNSResponse._parse_message_attributes due to
accidental recycling of a variable.

* Fix test_sns.test_publish_to_http in py36 env

Http response is encoded as a byte string which json.loads can't handle.
 2018-04-27 15:10:30 -07:00
Steve Pulec
f37bae5b57
Merge pull request #1574 from wblackconv/add-msg-attributes 
Include SNS message attributes with message body when delivering to SQS.
 2018-04-18 21:19:21 -04:00
Mike Grima
794b8ba59e SNS now supports all modern boto3 regions. 2018-04-18 11:29:02 -07:00
wblack
f401c60825 Include SNS message attributes with message body when delivering to SQS. 2018-04-18 13:42:36 +00:00
Steve Pulec
3373c5bf13 Fix SNS max subject length. Closes #1503. 2018-04-13 15:17:38 -04:00