b225e96ae0
* Placeholder to test Application Autoscaling. * Wire everything together and create a first passing test without any real functionality. * Get one test working properly. * Add some TODO items. * Reformat code with black * Second passing test for describe_scalable_targets. * New test for NextToken. * Add some tests for ParamValidationError and ValidationException. * black * Ensure scalable targets are being captured in an OrderedDict() for deterministic return later. * Add validation to describe_scalable_targets and register_scalable_target. * Fix tests. * Add creation_time, refactor, add ECS backend, and add failing test for checking that ecs service exists. * Add parameter validation. * Improved documentation for CONTRIBUTING.md Adds some details to give people an idea what's involved in adding new features/services * Integrate with ECS. * black * Refactor to allow implementation of SuspendedState. * Complete support for SuspendedState. * Bump up implementation coverage percentage. * Tidy up code; add comments. * Implement suggested changes from code review. * Minor refactorings for elegance. * README update Co-authored-by: Bert Blommers <bblommers@users.noreply.github.com>
124 lines
5.1 KiB
Python
124 lines
5.1 KiB
Python
from __future__ import unicode_literals
|
|
import boto3
|
|
from moto import mock_applicationautoscaling, mock_ecs
|
|
from moto.applicationautoscaling import models
|
|
from moto.applicationautoscaling.exceptions import AWSValidationException
|
|
from botocore.exceptions import ParamValidationError
|
|
from nose.tools import assert_raises
|
|
import sure # noqa
|
|
from botocore.exceptions import ClientError
|
|
from parameterized import parameterized
|
|
from .test_applicationautoscaling import register_scalable_target
|
|
|
|
DEFAULT_REGION = "us-east-1"
|
|
DEFAULT_ECS_CLUSTER = "default"
|
|
DEFAULT_ECS_TASK = "test_ecs_task"
|
|
DEFAULT_ECS_SERVICE = "sample-webapp"
|
|
DEFAULT_SERVICE_NAMESPACE = "ecs"
|
|
DEFAULT_RESOURCE_ID = "service/{}/{}".format(DEFAULT_ECS_CLUSTER, DEFAULT_ECS_SERVICE)
|
|
DEFAULT_SCALABLE_DIMENSION = "ecs:service:DesiredCount"
|
|
DEFAULT_MIN_CAPACITY = 1
|
|
DEFAULT_MAX_CAPACITY = 1
|
|
DEFAULT_ROLE_ARN = "test:arn"
|
|
|
|
|
|
@mock_applicationautoscaling
|
|
def test_describe_scalable_targets_no_params_should_raise_param_validation_errors():
|
|
client = boto3.client("application-autoscaling", region_name=DEFAULT_REGION)
|
|
with assert_raises(ParamValidationError):
|
|
client.describe_scalable_targets()
|
|
|
|
|
|
@mock_applicationautoscaling
|
|
def test_register_scalable_target_no_params_should_raise_param_validation_errors():
|
|
client = boto3.client("application-autoscaling", region_name=DEFAULT_REGION)
|
|
with assert_raises(ParamValidationError):
|
|
client.register_scalable_target()
|
|
|
|
|
|
@mock_applicationautoscaling
|
|
def test_register_scalable_target_with_none_service_namespace_should_raise_param_validation_errors():
|
|
client = boto3.client("application-autoscaling", region_name=DEFAULT_REGION)
|
|
with assert_raises(ParamValidationError):
|
|
register_scalable_target(client, ServiceNamespace=None)
|
|
|
|
|
|
@mock_applicationautoscaling
|
|
def test_describe_scalable_targets_with_invalid_scalable_dimension_should_return_validation_exception():
|
|
client = boto3.client("application-autoscaling", region_name=DEFAULT_REGION)
|
|
|
|
with assert_raises(ClientError) as err:
|
|
response = client.describe_scalable_targets(
|
|
ServiceNamespace=DEFAULT_SERVICE_NAMESPACE, ScalableDimension="foo",
|
|
)
|
|
err.response["Error"]["Code"].should.equal("ValidationException")
|
|
err.response["Error"]["Message"].split(":")[0].should.look_like(
|
|
"1 validation error detected"
|
|
)
|
|
err.response["ResponseMetadata"]["HTTPStatusCode"].should.equal(400)
|
|
|
|
|
|
@mock_applicationautoscaling
|
|
def test_describe_scalable_targets_with_invalid_service_namespace_should_return_validation_exception():
|
|
client = boto3.client("application-autoscaling", region_name=DEFAULT_REGION)
|
|
|
|
with assert_raises(ClientError) as err:
|
|
response = client.describe_scalable_targets(
|
|
ServiceNamespace="foo", ScalableDimension=DEFAULT_SCALABLE_DIMENSION,
|
|
)
|
|
err.response["Error"]["Code"].should.equal("ValidationException")
|
|
err.response["Error"]["Message"].split(":")[0].should.look_like(
|
|
"1 validation error detected"
|
|
)
|
|
err.response["ResponseMetadata"]["HTTPStatusCode"].should.equal(400)
|
|
|
|
|
|
@mock_applicationautoscaling
|
|
def test_describe_scalable_targets_with_multiple_invalid_parameters_should_return_validation_exception():
|
|
client = boto3.client("application-autoscaling", region_name=DEFAULT_REGION)
|
|
|
|
with assert_raises(ClientError) as err:
|
|
response = client.describe_scalable_targets(
|
|
ServiceNamespace="foo", ScalableDimension="bar",
|
|
)
|
|
err.response["Error"]["Code"].should.equal("ValidationException")
|
|
err.response["Error"]["Message"].split(":")[0].should.look_like(
|
|
"2 validation errors detected"
|
|
)
|
|
err.response["ResponseMetadata"]["HTTPStatusCode"].should.equal(400)
|
|
|
|
|
|
@mock_ecs
|
|
@mock_applicationautoscaling
|
|
def test_register_scalable_target_ecs_with_non_existent_service_should_return_validation_exception():
|
|
client = boto3.client("application-autoscaling", region_name=DEFAULT_REGION)
|
|
resource_id = "service/{}/foo".format(DEFAULT_ECS_CLUSTER)
|
|
|
|
with assert_raises(ClientError) as err:
|
|
register_scalable_target(client, ServiceNamespace="ecs", ResourceId=resource_id)
|
|
err.response["Error"]["Code"].should.equal("ValidationException")
|
|
err.response["Error"]["Message"].should.equal(
|
|
"ECS service doesn't exist: {}".format(resource_id)
|
|
)
|
|
err.response["ResponseMetadata"]["HTTPStatusCode"].should.equal(400)
|
|
|
|
|
|
@parameterized(
|
|
[
|
|
("ecs", "service/default/test-svc", "ecs:service:DesiredCount", True),
|
|
("ecs", "banana/default/test-svc", "ecs:service:DesiredCount", False),
|
|
("rds", "service/default/test-svc", "ecs:service:DesiredCount", False),
|
|
]
|
|
)
|
|
def test_target_params_are_valid_success(namespace, r_id, dimension, expected):
|
|
if expected is True:
|
|
models._target_params_are_valid(namespace, r_id, dimension).should.equal(
|
|
expected
|
|
)
|
|
else:
|
|
with assert_raises(AWSValidationException):
|
|
models._target_params_are_valid(namespace, r_id, dimension)
|
|
|
|
|
|
# TODO add a test for not-supplied MinCapacity or MaxCapacity (ValidationException)
|