Replace globals() call with a static mapping
(suggested in @spulec review)
This commit is contained in:
parent
6b581edb55
commit
26980f41a6
@ -25,6 +25,12 @@ from .workflow_type import WorkflowType
|
|||||||
from .workflow_execution import WorkflowExecution
|
from .workflow_execution import WorkflowExecution
|
||||||
|
|
||||||
|
|
||||||
|
KNOWN_SWF_TYPES = {
|
||||||
|
"activity": ActivityType,
|
||||||
|
"workflow": WorkflowType,
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
class SWFBackend(BaseBackend):
|
class SWFBackend(BaseBackend):
|
||||||
def __init__(self, region_name):
|
def __init__(self, region_name):
|
||||||
self.region_name = region_name
|
self.region_name = region_name
|
||||||
@ -119,7 +125,7 @@ class SWFBackend(BaseBackend):
|
|||||||
_type = domain.get_type(kind, name, version, ignore_empty=True)
|
_type = domain.get_type(kind, name, version, ignore_empty=True)
|
||||||
if _type:
|
if _type:
|
||||||
raise SWFTypeAlreadyExistsFault(_type)
|
raise SWFTypeAlreadyExistsFault(_type)
|
||||||
_class = globals()["{0}Type".format(kind.capitalize())]
|
_class = KNOWN_SWF_TYPES[kind]
|
||||||
_type = _class(name, version, **kwargs)
|
_type = _class(name, version, **kwargs)
|
||||||
domain.add_type(_type)
|
domain.add_type(_type)
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user